Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933140AbbD1HqM (ORCPT ); Tue, 28 Apr 2015 03:46:12 -0400 Received: from metis.ext.pengutronix.de ([92.198.50.35]:58120 "EHLO metis.ext.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932328AbbD1HqJ (ORCPT ); Tue, 28 Apr 2015 03:46:09 -0400 Date: Tue, 28 Apr 2015 09:45:54 +0200 From: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= To: Eddie Huang Cc: Lee Jones , Alessandro Zummo , Matthias Brugger , Andrew Morton , Tomasz Figa , Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= , Samuel Ortiz , rtc-linux@googlegroups.com, Greg KH , linux-kernel@vger.kernel.org, srv_heupstream@mediatek.com, linux-mediatek@lists.infradead.org, Joe Perches , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v3 1/3] mfd: provide RTC resource in MT6397 MFD Message-ID: <20150428074554.GZ19431@pengutronix.de> References: <1430206556-18254-1-git-send-email-eddie.huang@mediatek.com> <1430206556-18254-2-git-send-email-eddie.huang@mediatek.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1430206556-18254-2-git-send-email-eddie.huang@mediatek.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c0 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1677 Lines: 49 Hello, On Tue, Apr 28, 2015 at 03:35:54PM +0800, Eddie Huang wrote: > Provide MT6397 RTC interrupt, base address, and register in > MT6397 MFD. > > Signed-off-by: Eddie Huang > --- > drivers/mfd/mt6397-core.c | 18 ++++++++++++++++++ > 1 file changed, 18 insertions(+) > > diff --git a/drivers/mfd/mt6397-core.c b/drivers/mfd/mt6397-core.c > index 09bc780..08cfbd1 100644 > --- a/drivers/mfd/mt6397-core.c > +++ b/drivers/mfd/mt6397-core.c > @@ -21,9 +21,27 @@ > #include > #include > > +#define MT6397_RTC_BASE 0xe000 > +#define MT6397_RTC_SIZE 0x3e > + > +static const struct resource mt6397_rtc_resources[] = { > + { > + .start = MT6397_RTC_BASE, > + .end = MT6397_RTC_BASE + MT6397_RTC_SIZE, > + .flags = IORESOURCE_MEM, It's definitly a matter of taste if you align the rhs here, but if you do, do it consitently. That is, either make sure that all equal signs are in a single column (at least per struct resource), or use a single space between variable name and =. If you want to hear my personal preference: I always use a single space. As if you have to add .somelongvariablename = somevalue you have to touch all other lines, too, which is ugly. Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-K?nig | Industrial Linux Solutions | http://www.pengutronix.de/ | -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/