Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965540AbbD1MBH (ORCPT ); Tue, 28 Apr 2015 08:01:07 -0400 Received: from 12.mo5.mail-out.ovh.net ([46.105.39.65]:34577 "EHLO 12.mo5.mail-out.ovh.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965450AbbD1MBE (ORCPT ); Tue, 28 Apr 2015 08:01:04 -0400 X-Greylist: delayed 13043 seconds by postgrey-1.27 at vger.kernel.org; Tue, 28 Apr 2015 08:01:04 EDT Message-ID: <553F4382.2070402@effinnov.com> Date: Tue, 28 Apr 2015 10:23:30 +0200 From: =?UTF-8?B?Q2zDqW1lbnQgUGVycm9jaGF1ZA==?= User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: Valentin Rothberg CC: sameo@linux.intel.com, linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, lauro.venancio@openbossa.org, aloisio.almeida@openbossa.org, Paul Bolle , Andreas Ruprecht , hengelein Stefan Subject: Re: NFC: CONFIG_NFC_DEBUG not defined References: In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Ovh-Tracer-Id: 4865013498049456946 X-Ovh-Remote: 109.190.171.176 (176-171-190-109.dsl.ovh.fr) X-Ovh-Local: 213.186.33.20 (ns0.ovh.net) X-OVH-SPAMSTATE: OK X-OVH-SPAMSCORE: -100 X-OVH-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrfeektddrieekucetufdoteggodetrfcurfhrohhfihhlvgemucfqggfjnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: -100 X-VR-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrfeektddrieekucetufdoteggodetrfcurfhrohhfihhlvgemucfqggfjnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1335 Lines: 44 On Mon, Apr 27, 2015 at 9:03 AM, Valentin Rothberg wrote: > Hi Clément, > > your commit dece45855a8b ("NFC: nxp-nci: Add support for NXP NCI > chips") adds the Makefile drivers/nfc/nxp-nci/Makefile with the > following line: > > +ccflags-$(CONFIG_NFC_DEBUG) := -DDEBUG > > The Kconfig option NFC_DEBUG is not defined so the line turns out to > be a nop. There is another reference in drivers/nfc/Makefile. Is > there a patch queued somewhere to add the option? > > I found this issue with ./scripts/checkkconfigsymbols.py by diffing > v4.0 and v4.1-rc1. Hi Valentin, I only included this line because it was present in the upper-level Makefile drivers/nfc/Makefile . As far as I know, there is no plan to add this option to the configuration. What would the most sensible solution to this issue be ? Add the NFC Debug feature to the configuration ? Remove it altogether ? Regards, -- Clément Perrochaud Eff'Innov Technologies Caen, Aix-En-Provence, Grenoble Eff'Innov Technologies Campus EffiScience 2, Esplanade Anton Philips 14460 Colombelles, FRANCE http://www.effinnov.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/