Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933227AbbD1Ig2 (ORCPT ); Tue, 28 Apr 2015 04:36:28 -0400 Received: from mail-wi0-f170.google.com ([209.85.212.170]:36156 "EHLO mail-wi0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752648AbbD1IgY convert rfc822-to-8bit (ORCPT ); Tue, 28 Apr 2015 04:36:24 -0400 MIME-Version: 1.0 In-Reply-To: <553F4382.2070402@effinnov.com> References: <553F4382.2070402@effinnov.com> From: Valentin Rothberg Date: Tue, 28 Apr 2015 10:35:52 +0200 Message-ID: Subject: Re: NFC: CONFIG_NFC_DEBUG not defined To: =?UTF-8?Q?Cl=C3=A9ment_Perrochaud?= Cc: sameo@linux.intel.com, linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, lauro.venancio@openbossa.org, aloisio.almeida@openbossa.org, Paul Bolle , Andreas Ruprecht , hengelein Stefan Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1705 Lines: 57 Hi Clément, thanks for your answer. On Tue, Apr 28, 2015 at 10:23 AM, Clément Perrochaud wrote: > On Mon, Apr 27, 2015 at 9:03 AM, Valentin Rothberg wrote: >> Hi Clément, >> >> your commit dece45855a8b ("NFC: nxp-nci: Add support for NXP NCI >> chips") adds the Makefile drivers/nfc/nxp-nci/Makefile with the >> following line: >> >> +ccflags-$(CONFIG_NFC_DEBUG) := -DDEBUG >> >> The Kconfig option NFC_DEBUG is not defined so the line turns out to >> be a nop. There is another reference in drivers/nfc/Makefile. Is >> there a patch queued somewhere to add the option? >> >> I found this issue with ./scripts/checkkconfigsymbols.py by diffing >> v4.0 and v4.1-rc1. > > Hi Valentin, > > I only included this line because it was present in the upper-level > Makefile drivers/nfc/Makefile . As far as I know, there is no plan to > add this option to the configuration. > > What would the most sensible solution to this issue be ? Add the NFC > Debug feature to the configuration ? Remove it altogether ? DEBUG is not used in any of the files in drivers/nfc/ so I think we can safely remove the two lines from the Makefiles. Do you want me to prepare a patch? Kind regards, Valentin > Regards, > > -- > Clément Perrochaud > > Eff'Innov Technologies > Caen, Aix-En-Provence, Grenoble > > Eff'Innov Technologies > Campus EffiScience > 2, Esplanade Anton Philips > 14460 Colombelles, FRANCE > > http://www.effinnov.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/