Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933170AbbD1Iyv (ORCPT ); Tue, 28 Apr 2015 04:54:51 -0400 Received: from mail2.asahi-net.or.jp ([202.224.39.198]:25896 "EHLO mail2.asahi-net.or.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752938AbbD1Iys (ORCPT ); Tue, 28 Apr 2015 04:54:48 -0400 Date: Tue, 28 Apr 2015 17:54:46 +0900 Message-ID: <87h9s0vdih.wl-ysato@users.sourceforge.jp> From: Yoshinori Sato To: Arnd Bergmann Cc: linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org Subject: Re: [PATCH v9 07/17] h8300: miscellaneous functions In-Reply-To: <2426012.sTXZYqKJ88@wuerfel> References: <1430112924-1134-1-git-send-email-ysato@users.sourceforge.jp> <1430112924-1134-8-git-send-email-ysato@users.sourceforge.jp> <2426012.sTXZYqKJ88@wuerfel> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL/10.8 EasyPG/1.0.0 Emacs/24.4 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1538 Lines: 52 At Mon, 27 Apr 2015 10:57:10 +0200, Arnd Bergmann wrote: > > On Monday 27 April 2015 14:35:14 Yoshinori Sato wrote: > > +void dma_sync_single_for_device(struct device *dev, dma_addr_t handle, > > + size_t size, enum dma_data_direction dir) > > +{ > > +} > > +EXPORT_SYMBOL(dma_sync_single_for_device); > > + > > +void dma_sync_sg_for_device(struct device *dev, struct scatterlist *sg, > > + int nents, enum dma_data_direction dir) > > +{ > > + int i; > > + > > + for (i = 0; i < nents; sg++, i++) > > + dma_sync_single_for_device(dev, sg->dma_address, > > + sg->length, dir); > > +} > > +EXPORT_SYMBOL(dma_sync_sg_for_device); > > + > > +dma_addr_t dma_map_single(struct device *dev, void *addr, size_t size, > > + enum dma_data_direction dir) > > +{ > > + dma_addr_t handle = virt_to_bus(addr); > > + > > + dma_sync_single_for_device(dev, handle, size, dir); > > + return handle; > > +} > > +EXPORT_SYMBOL(dma_map_single); > > > As this all doesn't do anything, and your dma-mapping.h header explains > that the architecture is cache-coherent, just remove these functions, > and replace them with empty 'static inline' helpers in that header. > > Arnd > OK. This DMA support part too old. I will rewriting. Thanks. -- Yoshinori Sato -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/