Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965280AbbD1J0D (ORCPT ); Tue, 28 Apr 2015 05:26:03 -0400 Received: from mail-ig0-f169.google.com ([209.85.213.169]:38191 "EHLO mail-ig0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965201AbbD1JZz (ORCPT ); Tue, 28 Apr 2015 05:25:55 -0400 MIME-Version: 1.0 Reply-To: cw00.choi@samsung.com In-Reply-To: References: <54FF95ED.1040003@samsung.com> Date: Tue, 28 Apr 2015 18:25:54 +0900 Message-ID: Subject: Re: ARCH_EXYNOS5433 missing in Kconfig From: Chanwoo Choi To: Valentin Rothberg , Sylwester Nawrocki Cc: Tomasz Figa , Mike Turquette , Stephen Boyd , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Inki Dae , linux-kernel , linux-samsung-soc , linux-arm-kernel , devicetree , Andreas Ruprecht , hengelein Stefan , Paul Bolle , Arnd Bergmann , =?UTF-8?B?6rmA6rWt7KeEQGtlcm5lbC5vcmc=?= Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3737 Lines: 107 Hi Valentin, On Mon, Apr 27, 2015 at 3:31 PM, Valentin Rothberg wrote: > Hi Chanwoo, > > this is a kind reminder that the issue mentioned below is still > present and made its way to v4.1-rc1. I sent the patch[1] to fix it. And Sylwester said that he will pick this patchset on patch[2]. [1] https://lkml.org/lkml/2015/4/27/237 [2] https://lkml.org/lkml/2015/4/28/117 Hi Sylwester, Could you apply a patch[1] on 4.2-rc2 to fix build warning? Best Regards, Chanwoo Choi > > Kind regards, > Valentin > > On Wed, Mar 11, 2015 at 2:10 AM, Chanwoo Choi wrote: >> Hi Valentin, >> >> I sent the Exynos5433 clock patch and then separately I'm sending the >> Exynos5433 devicetree patch-set[1]. >> [1] [PATCH v6 0/9] arm64: Add the support for new Exynos5433 SoC >> - https://lkml.org/lkml/2015/3/9/1036 >> >> But, according to Arnd bergmann's comment[2], latest Exynos5433 dt patch-set[1] >> removed the CONFIG_ARCH_EXYNOS5433. >> [2] https://lkml.org/lkml/2015/2/24/85 >> >> >> So, I have plan to send following patch. >> >> --- >> clk: samsung: Use CONFIG_ARCH_EXYNOS instead of Exynos-specific configuration >> >> This patch removes the CONFIG_ARCH_EXYNOS{5433|7} and then use only the >> CONFIG_ARCH_EXYNOS for ARM-64bit Exynos SoC. >> >> Cc: Sylwester Nawrocki >> Cc: Tomasz Figa >> Cc: Arnd Bergmann >> Signed-off-by: Chanwoo Choi >> --- >> drivers/clk/samsung/Makefile | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/clk/samsung/Makefile b/drivers/clk/samsung/Makefile >> index 17e9af7..561719d 100644 >> --- a/drivers/clk/samsung/Makefile >> +++ b/drivers/clk/samsung/Makefile >> @@ -10,11 +10,11 @@ obj-$(CONFIG_SOC_EXYNOS5250) += clk-exynos5250.o >> obj-$(CONFIG_SOC_EXYNOS5260) += clk-exynos5260.o >> obj-$(CONFIG_SOC_EXYNOS5410) += clk-exynos5410.o >> obj-$(CONFIG_SOC_EXYNOS5420) += clk-exynos5420.o >> -obj-$(CONFIG_ARCH_EXYNOS5433) += clk-exynos5433.o >> +obj-$(CONFIG_ARCH_EXYNOS) += clk-exynos5433.o >> obj-$(CONFIG_SOC_EXYNOS5440) += clk-exynos5440.o >> obj-$(CONFIG_ARCH_EXYNOS) += clk-exynos-audss.o >> obj-$(CONFIG_ARCH_EXYNOS) += clk-exynos-clkout.o >> >> >> Regards, >> Chanwoo Choi >> >> >> On 03/11/2015 12:32 AM, Valentin Rothberg wrote: >>> Hi Chanwoo, >>> >>> your commit 96bd6224f07b ("clk: samsung: exynos5433: Add clocks using >>> common clock framework") is included in today's linux-next tree (i.e., >>> next-20150310). >>> >>> This patch conditionally compiles clk-exynos5433.c depending on the >>> Kconfig option ARCH_EXYNOS5433. However, this option is not defined >>> in Kconfig, so that the driver cannot be compiled at the current >>> state: >>> >>> +obj-$(CONFIG_ARCH_EXYNOS5433) += clk-exynos5433.o >>> >>> Is there a patch queued somewhere that adds this Kconfig symbol? I >>> detected the issue by running undertaker-checkpatch from the >>> Undertaker tool suite (undertaker.cs.fau.de). There is also a tool in >>> the git tree that can detect such issues (i.e., >>> scripts/checkkconfigsymbols.py). >>> >>> Kind regards, >>> Valentin >>> >> > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/