Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933117AbbD1Jxa (ORCPT ); Tue, 28 Apr 2015 05:53:30 -0400 Received: from cantor2.suse.de ([195.135.220.15]:56322 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752866AbbD1Jx2 (ORCPT ); Tue, 28 Apr 2015 05:53:28 -0400 Date: Tue, 28 Apr 2015 10:53:23 +0100 From: Mel Gorman To: Andrew Morton Cc: Linux-MM , Nathan Zimmer , Dave Hansen , Waiman Long , Scott Norton , Daniel J Blueman , LKML Subject: Re: [PATCH 07/13] mm: meminit: Initialise a subset of struct pages if CONFIG_DEFERRED_STRUCT_PAGE_INIT is set Message-ID: <20150428095323.GK2449@suse.de> References: <1429785196-7668-1-git-send-email-mgorman@suse.de> <1429785196-7668-8-git-send-email-mgorman@suse.de> <20150427154344.421fd9f151bf27d365d02fd2@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: <20150427154344.421fd9f151bf27d365d02fd2@linux-foundation.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1597 Lines: 42 On Mon, Apr 27, 2015 at 03:43:44PM -0700, Andrew Morton wrote: > On Thu, 23 Apr 2015 11:33:10 +0100 Mel Gorman wrote: > > > This patch initalises all low memory struct pages and 2G of the highest zone > > on each node during memory initialisation if CONFIG_DEFERRED_STRUCT_PAGE_INIT > > is set. That config option cannot be set but will be available in a later > > patch. Parallel initialisation of struct page depends on some features > > from memory hotplug and it is necessary to alter alter section annotations. > > > > ... > > > > +#ifdef CONFIG_DEFERRED_STRUCT_PAGE_INIT > > +#define __defermem_init __meminit > > +#define __defer_init __meminit > > +#else > > +#define __defermem_init > > +#define __defer_init __init > > +#endif > > Could we get some comments describing these? What they do, when and > where they should be used. I have a suspicion that the naming isn't > good, but I didn't spend a lot of time reverse-engineering the > intent... > Of course. The next version will have +/* + * Deferred struct page initialisation requires some early init functions that + * are removed before kswapd is up and running. The feature depends on memory + * hotplug so put the data and code required by deferred initialisation into + * the __meminit section where they are preserved. + */ -- Mel Gorman SUSE Labs -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/