Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965431AbbD1LT7 (ORCPT ); Tue, 28 Apr 2015 07:19:59 -0400 Received: from mail1.asahi-net.or.jp ([202.224.39.197]:61420 "EHLO mail1.asahi-net.or.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S964803AbbD1LTz (ORCPT ); Tue, 28 Apr 2015 07:19:55 -0400 Date: Tue, 28 Apr 2015 20:19:52 +0900 Message-ID: <87vbggijon.wl-ysato@users.sourceforge.jp> From: Yoshinori Sato To: Tobias Klauser Cc: linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org Subject: Re: [PATCH v9 01/17] h8300: Assembly headers. In-Reply-To: <20150427074241.GA11048@distanz.ch> References: <1430112924-1134-1-git-send-email-ysato@users.sourceforge.jp> <1430112924-1134-2-git-send-email-ysato@users.sourceforge.jp> <20150427074241.GA11048@distanz.ch> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL/10.8 EasyPG/1.0.0 Emacs/24.4 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3299 Lines: 99 At Mon, 27 Apr 2015 09:42:41 +0200, Tobias Klauser wrote: > > On 2015-04-27 at 07:35:08 +0200, Yoshinori Sato wrote: > [...] > > diff --git a/arch/h8300/include/asm/elf.h b/arch/h8300/include/asm/elf.h > > new file mode 100644 > > index 0000000..09031d0 > > --- /dev/null > > +++ b/arch/h8300/include/asm/elf.h > > @@ -0,0 +1,101 @@ > > +#ifndef __ASM_H8300_ELF_H > > +#define __ASM_H8300_ELF_H > > + > > +/* > > + * ELF register definitions.. > > + */ > > + > > +#include > > +#include > > + > > +typedef unsigned long elf_greg_t; > > + > > +#define ELF_NGREG (sizeof(struct user_regs_struct) / sizeof(elf_greg_t)) > > +typedef elf_greg_t elf_gregset_t[ELF_NGREG]; > > +typedef unsigned long elf_fpregset_t; > > + > > +/* > > + * This is used to ensure we don't load something for the wrong architecture. > > + */ > > +#define elf_check_arch(x) ((x)->e_machine == EM_H8_300) > > EM_H8_300 is still used before it is introduced in patch 15/17, please > change the patch order. Otherwise you break bisectability. Oh. sorry. I forgat change order. > [...] > > diff --git a/arch/h8300/include/asm/pgtable.h b/arch/h8300/include/asm/pgtable.h > > new file mode 100644 > > index 0000000..8341db6 > > --- /dev/null > > +++ b/arch/h8300/include/asm/pgtable.h > > @@ -0,0 +1,49 @@ > > +#ifndef _H8300_PGTABLE_H > > +#define _H8300_PGTABLE_H > > +#include > > +#include > > +#define pgtable_cache_init() do { } while (0) > > +extern void paging_init(void); > > +#define PAGE_NONE __pgprot(0) /* these mean nothing to NO_MM */ > > +#define PAGE_SHARED __pgprot(0) /* these mean nothing to NO_MM */ > > +#define PAGE_COPY __pgprot(0) /* these mean nothing to NO_MM */ > > +#define PAGE_READONLY __pgprot(0) /* these mean nothing to NO_MM */ > > +#define PAGE_KERNEL __pgprot(0) /* these mean nothing to NO_MM */ > > +#define __swp_type(x) (0) > > +#define __swp_offset(x) (0) > > +#define __swp_entry(typ, off) ((swp_entry_t) { ((typ) | ((off) << 7)) }) > > +#define __pte_to_swp_entry(pte) ((swp_entry_t) { pte_val(pte) }) > > +#define __swp_entry_to_pte(x) ((pte_t) { (x).val }) > > +#define kern_addr_valid(addr) (1) > > +#define pgprot_writecombine(prot) (prot) > > +#define pgprot_noncached pgprot_writecombine > > + > > +static inline int pte_file(pte_t pte) { return 0; } > > No need to define pte_file() anymore. Please see my review comments for > v8. OK. > > > +#define swapper_pg_dir ((pgd_t *) 0) > > +/* > > + * ZERO_PAGE is a global shared page that is always zero: used > > + * for zero-mapped memory areas etc.. > > + */ > > +#define ZERO_PAGE(vaddr) (virt_to_page(0)) > > + > > +/* > > + * These would be in other places but having them here reduces the diffs. > > + */ > > +extern unsigned int kobjsize(const void *objp); > > +extern int is_in_rom(unsigned long); > > These aren't needed as well, as mentioned in my earlier review comments. OK. Thanks. -- Yoshinori Sato -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/