Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965576AbbD1LiZ (ORCPT ); Tue, 28 Apr 2015 07:38:25 -0400 Received: from cantor2.suse.de ([195.135.220.15]:37050 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965298AbbD1LiY (ORCPT ); Tue, 28 Apr 2015 07:38:24 -0400 Date: Tue, 28 Apr 2015 12:38:20 +0100 From: Mel Gorman To: Andrew Morton Cc: Linux-MM , Nathan Zimmer , Dave Hansen , Waiman Long , Scott Norton , Daniel J Blueman , LKML Subject: Re: [PATCH 11/13] mm: meminit: Free pages in large chunks where possible Message-ID: <20150428113819.GL2449@suse.de> References: <1429785196-7668-1-git-send-email-mgorman@suse.de> <1429785196-7668-12-git-send-email-mgorman@suse.de> <20150427154356.67e3d186b732a2c2b00e49cb@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: <20150427154356.67e3d186b732a2c2b00e49cb@linux-foundation.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1116 Lines: 30 On Mon, Apr 27, 2015 at 03:43:56PM -0700, Andrew Morton wrote: > On Thu, 23 Apr 2015 11:33:14 +0100 Mel Gorman wrote: > > > Parallel struct page frees pages one at a time. Try free pages as single > > large pages where possible. > > > > ... > > > > void __defermem_init deferred_init_memmap(int nid) > > This function is gruesome in an 80-col display. Even the code comments > wrap, which is nuts. Maybe hoist the contents of the outermost loop > into a separate function, called for each zone? I can do better than that because only the highest zone is deferred in this version and the loop is no longer necessary. I should post a V4 before the end of my day that addresses your feedback. It caused a lot of conflicts and it'll be easier to replace the full series than try managing incremental fixes. Thanks Andrew. -- Mel Gorman SUSE Labs -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/