Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965389AbbD1LnZ (ORCPT ); Tue, 28 Apr 2015 07:43:25 -0400 Received: from verein.lst.de ([213.95.11.211]:40525 "EHLO newverein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S964975AbbD1LnW (ORCPT ); Tue, 28 Apr 2015 07:43:22 -0400 Date: Tue, 28 Apr 2015 13:43:20 +0200 From: Christoph Hellwig To: Ming Lin Cc: linux-kernel@vger.kernel.org, Christoph Hellwig , Jens Axboe , Kent Overstreet , Dongsu Park , Christoph Hellwig , Al Viro , Ming Lei , Neil Brown , Alasdair Kergon , Mike Snitzer , dm-devel@redhat.com, Lars Ellenberg , drbd-user@lists.linbit.com, Jiri Kosina , Geoff Levand , Jim Paris , Joshua Morris , Philip Kelleher , Minchan Kim , Nitin Gupta , Oleg Drokin , Andreas Dilger , Keith Busch Subject: Re: [PATCH 01/10] block: make generic_make_request handle arbitrarily sized bios Message-ID: <20150428114320.GA9790@lst.de> References: <1430203717-13307-1-git-send-email-mlin@kernel.org> <1430203717-13307-2-git-send-email-mlin@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1430203717-13307-2-git-send-email-mlin@kernel.org> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 544 Lines: 11 This seems to lack support for QUEUE_FLAG_SG_GAPS to work around the retarded PPR format in the NVMe driver. I'm actually not sure we have a way to reproduce them for BLOCK_PC requests, but I think we should make sure to properly handle them. Maybe Keith or Jens have a good reproducer for these. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/