Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965831AbbD1MMj (ORCPT ); Tue, 28 Apr 2015 08:12:39 -0400 Received: from verein.lst.de ([213.95.11.211]:40668 "EHLO newverein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965421AbbD1MMg (ORCPT ); Tue, 28 Apr 2015 08:12:36 -0400 Date: Tue, 28 Apr 2015 14:12:34 +0200 From: Christoph Hellwig To: Ming Lin Cc: linux-kernel@vger.kernel.org, Christoph Hellwig , Jens Axboe , Kent Overstreet , Dongsu Park , Christoph Hellwig Subject: Re: [PATCH 02/10] block: simplify bio_add_page() Message-ID: <20150428121234.GA10479@lst.de> References: <1430203717-13307-1-git-send-email-mlin@kernel.org> <1430203717-13307-3-git-send-email-mlin@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1430203717-13307-3-git-send-email-mlin@kernel.org> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 746 Lines: 16 On Mon, Apr 27, 2015 at 11:48:29PM -0700, Ming Lin wrote: > Note that removing call to ->merge_bvec_fn() is fine for > bio_add_pc_page(), as SCSI devices usually don't even need that. > Few exceptional cases like pscsi or osd are not affected either. This explanation confuses me. Based on my reading of the code I'd replace it with something like: Removing the call to ->merge_bvec_fn() is also fine, as no driver that implements support for BLOCK_PC commands even has a ->merge_bvec_fn() method. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/