Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965638AbbD1MWP (ORCPT ); Tue, 28 Apr 2015 08:22:15 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:49704 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965406AbbD1MWN (ORCPT ); Tue, 28 Apr 2015 08:22:13 -0400 Date: Tue, 28 Apr 2015 14:22:10 +0200 From: Greg Kroah-Hartman To: Peter Hurley Cc: Jiri Slaby , linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Alim Akhtar , Marek Szyprowski , tfiga@google.com, Chanwoo Choi , Arnd Bergmann Subject: Re: [PATCH] earlycon: Fix uart_parse_earlycon() if !CONFIG_SERIAL_CORE_CONSOLE Message-ID: <20150428122210.GA16972@kroah.com> References: <1428763356-29158-1-git-send-email-peter@hurleysoftware.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1428763356-29158-1-git-send-email-peter@hurleysoftware.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1116 Lines: 27 On Sat, Apr 11, 2015 at 10:42:36AM -0400, Peter Hurley wrote: > Arnd Bergmann wrote: > > A configuration that enables earlycon but not the core console > > code causes a link error: > > > > drivers/built-in.o: In function `setup_earlycon': > > drivers/tty/serial/earlycon.c:70: undefined reference to `uart_parse_earlycon' > > CONFIG_SERIAL_EARLYCON should not require CONFIG_SERIAL_CORE_CONSOLE. > Move uart_parse_earlycon() and compile if either CONFIG_SERIAL_CORE_CONSOLE > or CONFIG_SERIAL_EARLYCON. > > Reported-by: Arnd Bergmann > Signed-off-by: Peter Hurley > --- > > NB: The diff moves everything else around uart_parse_earlycon() :/ > > drivers/tty/serial/serial_core.c | 90 ++++++++++++++++++++-------------------- > 1 file changed, 46 insertions(+), 44 deletions(-) This doesn't apply to my tty-next branch :( -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/