Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965720AbbD1MXp (ORCPT ); Tue, 28 Apr 2015 08:23:45 -0400 Received: from mail-ob0-f177.google.com ([209.85.214.177]:35871 "EHLO mail-ob0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965421AbbD1MXo (ORCPT ); Tue, 28 Apr 2015 08:23:44 -0400 MIME-Version: 1.0 In-Reply-To: <1429890108.5211.8.camel@mm-sol.com> References: <1429742451-11465-1-git-send-email-mathieu.poirier@linaro.org> <1429742451-11465-2-git-send-email-mathieu.poirier@linaro.org> <1429890108.5211.8.camel@mm-sol.com> Date: Tue, 28 Apr 2015 14:23:43 +0200 Message-ID: Subject: Re: [PATCH 01/11] coresight-etm4x: Adding CoreSight ETM4x driver From: Linus Walleij To: "Ivan T. Ivanov" Cc: Mathieu Poirier , Greg KH , "linux-arm-kernel@lists.infradead.org" , "linux-api@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Kaixu Xia , Chunyan Zhang Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 915 Lines: 26 On Fri, Apr 24, 2015 at 5:41 PM, Ivan T. Ivanov wrote: > On Wed, 2015-04-22 at 16:40 -0600, Mathieu Poirier wrote: >> > >> +static struct amba_id etm4_ids[] = { >> + { /* ETM 4.0 - Hi6220 board */ >> + .id = 0x0003b95d, >> + .mask = 0x0003ffff, >> + .data = "ETM 4.0", >> + }, >> + { /* ETM 4.0 - Juno board */ >> + .id = 0x000bb95e, >> + .mask = 0x000bffff, > > Mask looks suspicious. I'm thinking that maybe we should have some masks predefined in for bits in this field so we get it right. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/