Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1031094AbbD1OK1 (ORCPT <rfc822;w@1wt.eu>);
	Tue, 28 Apr 2015 10:10:27 -0400
Received: from smtp.codeaurora.org ([198.145.29.96]:46159 "EHLO
	smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1031047AbbD1OKW (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 28 Apr 2015 10:10:22 -0400
Message-ID: <a6975524841300d9a2dfbfde2384aea8.squirrel@www.codeaurora.org>
In-Reply-To: <1429012281-24068-3-git-send-email-gbroner@codeaurora.org>
References: <1429012281-24068-1-git-send-email-gbroner@codeaurora.org>
    <1429012281-24068-3-git-send-email-gbroner@codeaurora.org>
Date: Tue, 28 Apr 2015 14:10:21 -0000
Subject: Re: [PATCH v8 2/3] scsi: ufs: add debugfs for ufs
From: "Dov Levenglick" <dovl@codeaurora.org>
To: "Gilad Broner" <gbroner@codeaurora.org>
Cc: james.bottomley@hansenpartnership.com, linux-kernel@vger.kernel.org,
        linux-scsi@vger.kernel.org, linux-arm-msm@vger.kernel.org,
        santoshsy@gmail.com, linux-scsi-owner@vger.kernel.org,
        subhashj@codeaurora.org, ygardi@codeaurora.org, draviv@codeaurora.org,
        "Lee Susman" <lsusman@codeaurora.org>,
        "Raviv Shvili" <rshvili@codeaurora.org>,
        "Gilad Broner" <gbroner@codeaurora.org>,
        "Vinayak Holikatti" <vinholikatti@gmail.com>,
        "James E.J. Bottomley" <jbottomley@odin.com>
User-Agent: SquirrelMail/1.4.22-4.el6
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7BIT
X-Priority: 3 (Normal)
Importance: Normal
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 2540
Lines: 71

Reviewed-by: Dov Levenglick <dovl@codeaurora.org>

> From: Lee Susman <lsusman@codeaurora.org>
>
> Adding debugfs capability for ufshcd.
>
> debugfs attributes introduced in this patch:
>  - View driver/controller runtime data
>  - Command tag statistics for performance analisis
>  - Dump device descriptor info
>  - Track recoverable errors statistics during runtime
>  - Change UFS power mode during runtime
>      entry a string in the format 'GGLLMM' where:
>          G - selected gear
>          L - number of lanes
>          M - power mode
>              (1=fast mode, 2=slow mode, 4=fast-auto mode,
>               5=slow-auto mode)
>      First letter is for RX, second is for TX.
>  - Get/set DME attributes
>
> Signed-off-by: Lee Susman <lsusman@codeaurora.org>
> Signed-off-by: Dolev Raviv <draviv@codeaurora.org>
> Signed-off-by: Yaniv Gardi <ygardi@codeaurora.org>
> Signed-off-by: Raviv Shvili <rshvili@codeaurora.org>
> Signed-off-by: Gilad Broner <gbroner@codeaurora.org>
> ---
>  drivers/scsi/ufs/Makefile      |   3 +-
>  drivers/scsi/ufs/ufs-debugfs.c | 901
> +++++++++++++++++++++++++++++++++++++++++
>  drivers/scsi/ufs/ufs-debugfs.h |  38 ++
>  drivers/scsi/ufs/ufshcd.c      | 229 ++++++++++-
>  drivers/scsi/ufs/ufshcd.h      |  65 +++
>  drivers/scsi/ufs/ufshci.h      |   2 +
>  6 files changed, 1225 insertions(+), 13 deletions(-)
>  create mode 100644 drivers/scsi/ufs/ufs-debugfs.c
>  create mode 100644 drivers/scsi/ufs/ufs-debugfs.h
>

<snip many lines of code>

> @@ -72,6 +72,8 @@ enum {
>  	REG_UIC_COMMAND_ARG_1			= 0x94,
>  	REG_UIC_COMMAND_ARG_2			= 0x98,
>  	REG_UIC_COMMAND_ARG_3			= 0x9C,
> +
> +	UFSHCI_REG_SPACE_SIZE			= 0xA0,
>  };
>
>  /* Controller capability masks */
> --
> Qualcomm Israel, on behalf of Qualcomm Innovation Center, Inc.
> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
> a Linux Foundation Collaborative Project
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>


QUALCOMM ISRAEL, on behalf of Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/