Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1031127AbbD1Ohu (ORCPT ); Tue, 28 Apr 2015 10:37:50 -0400 Received: from static.88-198-71-155.clients.your-server.de ([88.198.71.155]:51230 "EHLO socrates.bennee.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1030319AbbD1Ohq (ORCPT ); Tue, 28 Apr 2015 10:37:46 -0400 References: <1427814488-28467-1-git-send-email-alex.bennee@linaro.org> <1427814488-28467-7-git-send-email-alex.bennee@linaro.org> <20150414082558.GS6186@cbox> <87y4li6hua.fsf@linaro.org> <20150427200407.GG23335@cbox> <87wq0wr6dd.fsf@linaro.org> <20150428125645.GA4137@cbox> From: Alex =?utf-8?Q?Benn=C3=A9e?= To: Christoffer Dall Cc: Peter Maydell , kvm-devel , arm-mail-list , "kvmarm\@lists.cs.columbia.edu" , Marc Zyngier , Alexander Graf , Andrew Jones , Paolo Bonzini , Zhichao Huang , "J. Kiszka" , David Hildenbrand , Bharat Bhushan , bp@suse.de, Gleb Natapov , Jonathan Corbet , Russell King , Catalin Marinas , Will Deacon , "open list\:DOCUMENTATION" , open list Subject: Re: [PATCH v2 06/10] KVM: arm64: guest debug, add SW break point support Message-ID: <87tww0qqh9.fsf@linaro.org> In-reply-to: <20150428125645.GA4137@cbox> Date: Tue, 28 Apr 2015 15:37:01 +0100 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-SA-Exim-Connect-IP: 127.0.0.1 X-SA-Exim-Mail-From: alex.bennee@linaro.org X-SA-Exim-Scanned: No (on socrates.bennee.com); SAEximRunCond expanded to false Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1963 Lines: 42 Christoffer Dall writes: > On Tue, Apr 28, 2015 at 10:34:12AM +0100, Peter Maydell wrote: >> On 28 April 2015 at 09:42, Alex Bennée wrote: >> > Peter Maydell writes: >> >> Does the kernel already have a conveniently implemented "inject >> >> exception into guest" lump of code? If so it might be less effort >> >> to do it that way round, maybe. >> > >> > So you pointed out we can't just re-inject the exceptions we get as we >> > need to map from things like ESR_ELx_EC_WATCHPT_LOW to >> > ESR_ELx_EC_WATCHPT_CUR before re-injection. >> > >> > Of course if it is as simple as modifying the ESR_EL1 register and >> > returning +ve in the handle_exit path then I can do that but I assumed >> > if any other wrangling needs doing it should be done in userspace. >> >> Well, somebody's got to do it, and it's the same amount of work >> either way (fiddling with ESR, making sure we direct the guest >> to the right exception vector entry point, maybe a few other >> things). >> > We already have code in the kernel to inject data/instruction aborts, > but not sure how much benefit there is in re-using that. It's up to you > really, but I think the kernel code should be clear about what the > intention is so that we don't end up in a situation where: (1) The > intended behavior is unclear/vague, and (2) it doesn't actually work in > practice so nobody can follow the code. Certainly there are some cases where the kernel doesn't have all the information. For example it doesn't know if the soft break was inserted by the guest or the host. That to me favours the "let userspace deal with the ugly" approach. -- Alex Bennée -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/