Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1030303AbbD1Pq7 (ORCPT ); Tue, 28 Apr 2015 11:46:59 -0400 Received: from arroyo.ext.ti.com ([192.94.94.40]:35531 "EHLO arroyo.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965942AbbD1Pq5 (ORCPT ); Tue, 28 Apr 2015 11:46:57 -0400 Date: Tue, 28 Apr 2015 10:45:01 -0500 From: Felipe Balbi To: "Du, Changbin" CC: "stable@vger.kernel.org" , "balbi@ti.com" , "gregkh@linuxfoundation.org" , "linux-usb@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "Cohen, David A" , "Wu, Hao" Subject: Re: [PATCH] usb: gadget: composite: enable BESL support Message-ID: <20150428154501.GA18263@saruman.tx.rr.com> Reply-To: References: <0C18FE92A7765D4EB9EE5D38D86A563A01CDD6AE@SHSMSX103.ccr.corp.intel.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="gKMricLos+KVdGMg" Content-Disposition: inline In-Reply-To: <0C18FE92A7765D4EB9EE5D38D86A563A01CDD6AE@SHSMSX103.ccr.corp.intel.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3452 Lines: 96 --gKMricLos+KVdGMg Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Apr 28, 2015 at 07:56:13AM +0000, Du, Changbin wrote: > From a6615937bcd9234e6d6bb817c3701fce44d0a84d Mon Sep 17 00:00:00 2001 > From: Felipe Balbi > Date: Tue, 30 Sep 2014 16:08:03 -0500 > Subject: [PATCH] usb: gadget: composite: enable BESL support missing upstream commit. > According to USB 2.0 ECN Errata for Link Power > Management (USB2-LPM-Errata-final.pdf), BESL > must be enabled if LPM is enabled. >=20 > This helps with USB30CV TD 9.21 LPM L1 > Suspend Resume Test. >=20 > Cc: # 3.14 this should be backported all the way back to 3.1. The commit which this patch is fixing, was applied on v3.1, so we're probably going to backport to 3.10 and 3.14. When asking for backports, don't consider only your project, think about the kernel/stable releases as a whole. BTW, that should be v3.1+, the + tells the Stable team that from v3.1 forward, all kernels need the backport. > Signed-off-by: Felipe Balbi > Signed-off-by: Du, Changbin > --- > Hi, >=20 > This patch was introduced on v3.18. However the issue fixed already exist= ed on > v3.14 and v3.14 is a long term support version. the issue already existed on v3.1, why did you decide to backport only to v3.14 ? > So propose to backport it over there as well. >=20 > Du, Changbin > --- > drivers/usb/gadget/composite.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/drivers/usb/gadget/composite.c b/drivers/usb/gadget/composit= e.c > index a8c18df..f6a51fd 100644 > --- a/drivers/usb/gadget/composite.c > +++ b/drivers/usb/gadget/composite.c > @@ -560,7 +560,7 @@ static int bos_desc(struct usb_composite_dev *cdev) > usb_ext->bLength =3D USB_DT_USB_EXT_CAP_SIZE; > usb_ext->bDescriptorType =3D USB_DT_DEVICE_CAPABILITY; > usb_ext->bDevCapabilityType =3D USB_CAP_TYPE_EXT; > - usb_ext->bmAttributes =3D cpu_to_le32(USB_LPM_SUPPORT); > + usb_ext->bmAttributes =3D cpu_to_le32(USB_LPM_SUPPORT | USB_BESL_SUPPOR= T); > =20 > /* > * The Superspeed USB Capability descriptor shall be implemented by all --=20 balbi --gKMricLos+KVdGMg Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJVP6r9AAoJEIaOsuA1yqREG2MQAJxDymV95RzBASaB2qJLJl5B o++HSpVoinoJgsyPr/qw3l2/ebD/k+tZGbGW4i/JGjV8dIEUf+M+wr7nLe/e+58f Rrjxl9Wd1Ber6VbTb9ddiQee6jVPsF98OWXndBtzFOWNqsIVDmrry5NuVCGrf4Go X7gHtErAfAurK/u9o/+Pcys0kdryPq95cbqE5rZVSa/YSoOBOVlvDAVwpmAQoxLp t8nFZsxAMnLsL7hh+XQ0hvDezBjKcPkz4mYEPnR7C2UUxxpLuM9P6qiKQZPzRzUg vjNocLoXKxYMAVWWD/Xxrr1Im6qhlGzmv2UrHsGHb8TTxg3C4bkxymhxN3ZT1dx3 Ftz4OuoweWWgz5bTISJhXAEDnrrYA3tTR1mUuwLaZg7EMur4uIoBZdvyVpbjC4UR 5SX++3kFsHcM096zPjziTnYpWxi4+IqCRvpsDMfrRJprKOtt7dRG7U1D0WdYr5R6 snq1IBIUh3bDf0VATRfnX5bSUbBbq1vodYO8GqOhV4QyZ+HFsuBC9NrWMEoHD1mR UZWzL2IvtmYeb/VL9cOUOi4ub+3krVTluhEfYMrMIHr7y66BJz+1uC2yHlqlOJJD PuQPDBiMKacpiMR+2I9/18v4jJAUSxqKUT4PpTd6Bkkb9VIRJmB0ezoURJLPg35O J9wSNh5GR0AwHA7GBVwX =ZGYG -----END PGP SIGNATURE----- --gKMricLos+KVdGMg-- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/