Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1030720AbbD1Qlp (ORCPT ); Tue, 28 Apr 2015 12:41:45 -0400 Received: from down.free-electrons.com ([37.187.137.238]:59489 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1030247AbbD1Qln (ORCPT ); Tue, 28 Apr 2015 12:41:43 -0400 Message-ID: <553FB845.30002@free-electrons.com> Date: Tue, 28 Apr 2015 18:41:41 +0200 From: Gregory CLEMENT User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: Valentin Rothberg , Paul Bolle CC: jason@lakedaemon.net, andrew@lunn.ch, sebastian.hesselbarth@gmail.com, linux@arm.linux.org.uk, linux-kernel@vger.kernel.org Subject: Re: [PATCH] arch/arm/mach-mvebu/Kconfig: remove obsolete selects References: <1430236970-14194-1-git-send-email-valentinrothberg@gmail.com> In-Reply-To: <1430236970-14194-1-git-send-email-valentinrothberg@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2118 Lines: 69 Hi Valentin, On 28/04/2015 18:02, Valentin Rothberg wrote: > ARM_ERRATA_753970 is not defined in Kconfig, so that both selects turn > out to be nops. Hence, we can safely remove them. It was already pointed by Paul Bolle a few months ago: http://thread.gmane.org/gmane.linux.kernel/1868817 and I thought it was applied. He pointed that the original intent was to select PL310_ERRATA_753970. Initially I was not sure if we needed it. In the meantime I didn't get any answer from the hardware designers but this errata affects the r3p0 version and according to the Cache ID register the PL310 used on these two SoCs were the r3p3. At the end I don't know which one of the patches to apply... But in any case I will add Acked-by: Gregory CLEMENT Thanks, Gregory > > Signed-off-by: Valentin Rothberg > --- > I detected this issue with scripts/checkkconfigsymbols.py > --- > arch/arm/mach-mvebu/Kconfig | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/arch/arm/mach-mvebu/Kconfig b/arch/arm/mach-mvebu/Kconfig > index 97473168d6b6..b9f1b63b169c 100644 > --- a/arch/arm/mach-mvebu/Kconfig > +++ b/arch/arm/mach-mvebu/Kconfig > @@ -37,7 +37,6 @@ config MACH_ARMADA_370 > config MACH_ARMADA_375 > bool "Marvell Armada 375 boards" if ARCH_MULTI_V7 > select ARM_ERRATA_720789 > - select ARM_ERRATA_753970 > select ARM_GIC > select ARMADA_375_CLK > select HAVE_ARM_SCU > @@ -52,7 +51,6 @@ config MACH_ARMADA_375 > config MACH_ARMADA_38X > bool "Marvell Armada 380/385 boards" if ARCH_MULTI_V7 > select ARM_ERRATA_720789 > - select ARM_ERRATA_753970 > select ARM_GIC > select ARMADA_38X_CLK > select HAVE_ARM_SCU > -- Gregory Clement, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/