Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1030775AbbD1QuR (ORCPT ); Tue, 28 Apr 2015 12:50:17 -0400 Received: from comal.ext.ti.com ([198.47.26.152]:36744 "EHLO comal.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1030578AbbD1QuK (ORCPT ); Tue, 28 Apr 2015 12:50:10 -0400 Message-ID: <553FBA28.40403@ti.com> Date: Tue, 28 Apr 2015 11:49:44 -0500 From: Suman Anna User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: Andrew Bresticker , Stephen Warren , Thierry Reding , Alexandre Courbot CC: "linux-tegra@vger.kernel.org" , "linux-usb@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , Jassi Brar Subject: Re: [PATCH V7 2/9] mailbox: Make struct mbox_controller's ops field const References: <1430174242-29465-1-git-send-email-abrestic@chromium.org> <1430174242-29465-3-git-send-email-abrestic@chromium.org> In-Reply-To: <1430174242-29465-3-git-send-email-abrestic@chromium.org> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1152 Lines: 40 Hi Andrew, On 04/27/2015 05:37 PM, Andrew Bresticker wrote: > The mailbox controller's channel ops ought to be read-only. We ought to change this on all the existing controllers as well. regards Suman > > Signed-off-by: Andrew Bresticker > Cc: Jassi Brar > --- > No changes from v5/v6. > New for v5. > --- > include/linux/mailbox_controller.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/linux/mailbox_controller.h b/include/linux/mailbox_controller.h > index d4cf96f..68c4245 100644 > --- a/include/linux/mailbox_controller.h > +++ b/include/linux/mailbox_controller.h > @@ -72,7 +72,7 @@ struct mbox_chan_ops { > */ > struct mbox_controller { > struct device *dev; > - struct mbox_chan_ops *ops; > + const struct mbox_chan_ops *ops; > struct mbox_chan *chans; > int num_chans; > bool txdone_irq; > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/