Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1031283AbbD1Scm (ORCPT ); Tue, 28 Apr 2015 14:32:42 -0400 Received: from mail-lb0-f182.google.com ([209.85.217.182]:33836 "EHLO mail-lb0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1030656AbbD1S1M (ORCPT ); Tue, 28 Apr 2015 14:27:12 -0400 Message-ID: <553FD0FC.3090704@cogentembedded.com> Date: Tue, 28 Apr 2015 21:27:08 +0300 From: Sergei Shtylyov Organization: Cogent Embedded User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: "K. Y. Srinivasan" , davem@davemloft.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, devel@linuxdriverproject.org, olaf@aepfle.de, apw@canonical.com, jasowang@redhat.com Subject: Re: [PATCH net 1/1] hv_netvsc: Fix a bug in netvsc_start_xmit() References: <1430183690-24198-1-git-send-email-kys@microsoft.com> In-Reply-To: <1430183690-24198-1-git-send-email-kys@microsoft.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 760 Lines: 24 Hello. On 04/28/2015 04:14 AM, K. Y. Srinivasan wrote: > Commit commit b08cc79155fc26d0d112b1470d1ece5034651a4b eliminated memory One "commit" is enough. :-) And please also specify that commit's summary in parens. > allocation in the packet send path. This commit introduced a bug since it > did not account for the case if the skb was cloned. Fix this bug by > using the pre-reserved head room only if the skb is not cloned. > Signed-off-by: K. Y. Srinivasan [...] WBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/