Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1030803AbbD1S77 (ORCPT ); Tue, 28 Apr 2015 14:59:59 -0400 Received: from mail-by2on0122.outbound.protection.outlook.com ([207.46.100.122]:11521 "EHLO na01-by2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1030524AbbD1S76 convert rfc822-to-8bit (ORCPT ); Tue, 28 Apr 2015 14:59:58 -0400 From: KY Srinivasan To: Sergei Shtylyov , "davem@davemloft.net" , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "devel@linuxdriverproject.org" , "olaf@aepfle.de" , "apw@canonical.com" , "jasowang@redhat.com" Subject: RE: [PATCH net 1/1] hv_netvsc: Fix a bug in netvsc_start_xmit() Thread-Topic: [PATCH net 1/1] hv_netvsc: Fix a bug in netvsc_start_xmit() Thread-Index: AQHQgUW042sUeQfzBEWjjrDct92Exp1iv1MAgAAJChA= Date: Tue, 28 Apr 2015 18:59:55 +0000 Message-ID: References: <1430183690-24198-1-git-send-email-kys@microsoft.com> <553FD0FC.3090704@cogentembedded.com> In-Reply-To: <553FD0FC.3090704@cogentembedded.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: cogentembedded.com; dkim=none (message not signed) header.d=none; x-originating-ip: [131.107.192.122] x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BY2PR0301MB0709; x-o365ent-eop-header: Message processed by - O365_ENT: Allow from ranges (Engineering ONLY) x-forefront-antispam-report: BMV:1;SFV:NSPM;SFS:(10019020)(6009001)(377454003)(51704005)(13464003)(24454002)(479174004)(92566002)(2900100001)(87936001)(2501003)(46102003)(33656002)(86362001)(74316001)(86612001)(575784001)(2656002)(19580395003)(99286002)(40100003)(66066001)(62966003)(107886001)(2950100001)(5001770100001)(76576001)(102836002)(54356999)(77156002)(19580405001)(122556002)(76176999)(2201001)(50986999)(106116001);DIR:OUT;SFP:1102;SCL:1;SRVR:BY2PR0301MB0709;H:BY2PR0301MB0711.namprd03.prod.outlook.com;FPR:;SPF:None;MLV:sfv;LANG:en; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(601004)(5002010)(5005006)(3002001);SRVR:BY2PR0301MB0709;BCL:0;PCL:0;RULEID:;SRVR:BY2PR0301MB0709; x-forefront-prvs: 0560A2214D Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 X-OriginatorOrg: microsoft.onmicrosoft.com X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Apr 2015 18:59:55.7296 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY2PR0301MB0709 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1225 Lines: 38 > -----Original Message----- > From: Sergei Shtylyov [mailto:sergei.shtylyov@cogentembedded.com] > Sent: Tuesday, April 28, 2015 11:27 AM > To: KY Srinivasan; davem@davemloft.net; netdev@vger.kernel.org; linux- > kernel@vger.kernel.org; devel@linuxdriverproject.org; olaf@aepfle.de; > apw@canonical.com; jasowang@redhat.com > Subject: Re: [PATCH net 1/1] hv_netvsc: Fix a bug in netvsc_start_xmit() > > Hello. > > On 04/28/2015 04:14 AM, K. Y. Srinivasan wrote: > > > Commit commit b08cc79155fc26d0d112b1470d1ece5034651a4b eliminated > memory > > One "commit" is enough. :-) > And please also specify that commit's summary in parens. > > > allocation in the packet send path. This commit introduced a bug since it > > did not account for the case if the skb was cloned. Fix this bug by > > using the pre-reserved head room only if the skb is not cloned. > > > Signed-off-by: K. Y. Srinivasan > > [...] > > WBR, Sergei Will do; thanks. K. Y -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/