Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1030918AbbD1TKa (ORCPT ); Tue, 28 Apr 2015 15:10:30 -0400 Received: from lb3-smtp-cloud2.xs4all.net ([194.109.24.29]:52490 "EHLO lb3-smtp-cloud2.xs4all.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1030524AbbD1TK3 (ORCPT ); Tue, 28 Apr 2015 15:10:29 -0400 Message-ID: <1430248224.2411.68.camel@x220> Subject: Re: [PATCH] drivers/scsi/arm/acornscsi.c: rename CONFIG_ACORNSCSI_CONSTANTS From: Paul Bolle To: Valentin Rothberg Cc: JBottomley@odin.com, linux@arm.linux.org.uk, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org Date: Tue, 28 Apr 2015 21:10:24 +0200 In-Reply-To: <1430230511-10869-1-git-send-email-valentinrothberg@gmail.com> References: <1430230511-10869-1-git-send-email-valentinrothberg@gmail.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.10.4 (3.10.4-4.fc20) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 717 Lines: 19 On Tue, 2015-04-28 at 16:15 +0200, Valentin Rothberg wrote: > CONFIG_ACORNSCSI_CONSTANTS is a file local CPP identifier and thereby > violates the naming convention of Kconfig options in Make and CPP > syntax; only Kconfig options should carry the 'CONFIG_' prefix. > > This patch removes the 'CONFIG_' prefix to apply to this convention and > to make static analysis tools happy. Will the Erlangen bot still spot ACORNSCSI_CONSTANTS as a potential issue? Paul Bolle -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/