Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1031112AbbD1T6S (ORCPT ); Tue, 28 Apr 2015 15:58:18 -0400 Received: from mail-wg0-f49.google.com ([74.125.82.49]:33043 "EHLO mail-wg0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1030737AbbD1T6R (ORCPT ); Tue, 28 Apr 2015 15:58:17 -0400 MIME-Version: 1.0 In-Reply-To: <1430249682.2411.79.camel@x220> References: <1430230511-10869-1-git-send-email-valentinrothberg@gmail.com> <1430248224.2411.68.camel@x220> <1430249682.2411.79.camel@x220> From: Valentin Rothberg Date: Tue, 28 Apr 2015 21:57:45 +0200 Message-ID: Subject: Re: [PATCH] drivers/scsi/arm/acornscsi.c: rename CONFIG_ACORNSCSI_CONSTANTS To: Paul Bolle Cc: JBottomley@odin.com, linux@arm.linux.org.uk, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1724 Lines: 42 On Tue, Apr 28, 2015 at 9:34 PM, Paul Bolle wrote: > Hi Valentin, > > On Tue, 2015-04-28 at 21:26 +0200, Valentin Rothberg wrote: >> On Tue, Apr 28, 2015 at 9:10 PM, Paul Bolle wrote: >> > Will the Erlangen bot still spot ACORNSCSI_CONSTANTS as a potential >> > issue? >> >> No, undertaker-checkpatch won't complain about this. There are >> thousands of such cases (i.e., without CONFIG_ prefix) around in the >> code (mostly #ifdef DEBUG). But most of them are intentionally dead >> or related to debugging, so they are ignored to avoid having false >> positives. > > Well, in a few years time, once undertaker-checkpatch has stomped out > most of the faux Kconfig preprocessor checks, that might be an area to > cover too. Or is that issue, ie pointless preprocessor checks, harder > than one might naively think? To give a number from Linus' tree today: 4706 of such unprefixed dead and undead #ifdefs and 940 'real' ones. Most of them are intentional -- this doesn't mean that it's not a problem. Personally, I don't like to have code around that cannot at least be easily test compiled; we manually need to (un)define the identifiers. I like your proposal. For symbolic issues, we could even put that directly in checkkconfigsymbols.py, so a big part of the problem could be solved directly with Kernel tools. But I really hope that it won't take a few years until we get there : ) Valentin > Thanks, > > > Paul Bolle > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/