Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966097AbbD1Ucm (ORCPT ); Tue, 28 Apr 2015 16:32:42 -0400 Received: from mail-oi0-f49.google.com ([209.85.218.49]:35715 "EHLO mail-oi0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965792AbbD1Ucj (ORCPT ); Tue, 28 Apr 2015 16:32:39 -0400 MIME-Version: 1.0 In-Reply-To: <1430209858.1904.1.camel@mm-sol.com> References: <1429742451-11465-1-git-send-email-mathieu.poirier@linaro.org> <1429742451-11465-2-git-send-email-mathieu.poirier@linaro.org> <1429890108.5211.8.camel@mm-sol.com> <1430209858.1904.1.camel@mm-sol.com> Date: Tue, 28 Apr 2015 14:32:38 -0600 Message-ID: Subject: Re: [PATCH 01/11] coresight-etm4x: Adding CoreSight ETM4x driver From: Mathieu Poirier To: "Ivan T. Ivanov" Cc: Greg KH , "linux-arm-kernel@lists.infradead.org" , linux-api@vger.kernel.org, "linux-kernel@vger.kernel.org" , Kaixu Xia , Chunyan Zhang Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1169 Lines: 33 On 28 April 2015 at 02:30, Ivan T. Ivanov wrote: > > On Mon, 2015-04-27 at 09:48 -0600, Mathieu Poirier wrote: >> On 24 April 2015 at 09:41, Ivan T. Ivanov wrote: >> > On Wed, 2015-04-22 at 16:40 -0600, Mathieu Poirier wrote: >> > >> > > +static struct amba_id etm4_ids[] = { >> > > + { /* ETM 4.0 - Hi6220 board */ >> > > + .id = 0x0003b95d, >> > > + .mask = 0x0003ffff, >> > > + .data = "ETM 4.0", >> > > + }, >> > > + { /* ETM 4.0 - Juno board */ >> > > + .id = 0x000bb95e, >> > > + .mask = 0x000bffff, >> > >> > Mask looks suspicious. >> >> Can you please expand the "suspicious" part ? > > Well, 'b' part of the mask. I have to admit that > I don't know how this is mapped on this platform. Yes, I see it now - thanks for pointing that out. > > Regards, > Ivan -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/