Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1031354AbbD1W6e (ORCPT ); Tue, 28 Apr 2015 18:58:34 -0400 Received: from smtprelay.synopsys.com ([198.182.47.9]:35009 "EHLO smtprelay.synopsys.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1031169AbbD1W6Z convert rfc822-to-8bit (ORCPT ); Tue, 28 Apr 2015 18:58:25 -0400 From: John Youn To: Yunzhi Li , "John.Youn@synopsys.com" , "gregory.herrero@intel.com" , "yousaf.kaukab@intel.com" , "linux-usb@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "balbi@ti.com" CC: "linux-rockchip@lists.infradead.org" , "rockchip-discuss@chromium.org" Subject: Re: [PATCH] usb: dwc2: gadget: cleanup useless code Thread-Topic: [PATCH] usb: dwc2: gadget: cleanup useless code Thread-Index: AQHQf/OofiN3kaQAyUSZyHWFT2LDxw== Date: Tue, 28 Apr 2015 22:58:22 +0000 Message-ID: <2B3535C5ECE8B5419E3ECBE300772909017522C3D5@US01WEMBX2.internal.synopsys.com> References: <1430033738-20914-1-git-send-email-lyz@rock-chips.com> <2B3535C5ECE8B5419E3ECBE300772909017522C15E@US01WEMBX2.internal.synopsys.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.10.161.106] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1158 Lines: 38 On 4/28/2015 3:50 PM, John Youn wrote: > On 4/26/2015 12:36 AM, Yunzhi Li wrote: >> dwc2 gadget driver s3c_hsotg_of_probe() run twice in >> dwc2_gadget_init() and the first one is useless, so remove it. >> >> Signed-off-by: Yunzhi Li >> --- >> drivers/usb/dwc2/gadget.c | 2 -- >> 1 file changed, 2 deletions(-) >> >> diff --git a/drivers/usb/dwc2/gadget.c b/drivers/usb/dwc2/gadget.c >> index 6a30887..2ae74f2 100644 >> --- a/drivers/usb/dwc2/gadget.c >> +++ b/drivers/usb/dwc2/gadget.c >> @@ -3851,8 +3851,6 @@ int dwc2_gadget_init(struct dwc2_hsotg *hsotg, int irq) >> /* Set default UTMI width */ >> hsotg->phyif = GUSBCFG_PHYIF16; >> >> - s3c_hsotg_of_probe(hsotg); >> - >> /* Initialize to legacy fifo configuration values */ >> hsotg->g_rx_fifo_sz = 2048; >> hsotg->g_np_g_tx_fifo_sz = 1024; >> > > > Acked-by: John Youn > Added Felipe. John -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/