Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1031315AbbD2DVn (ORCPT <rfc822;w@1wt.eu>);
	Tue, 28 Apr 2015 23:21:43 -0400
Received: from mga11.intel.com ([192.55.52.93]:52137 "EHLO mga11.intel.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1031217AbbD2DVl convert rfc822-to-8bit (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 28 Apr 2015 23:21:41 -0400
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.11,668,1422950400"; 
   d="scan'208";a="687214321"
From: "Ma, Xindong" <xindong.ma@intel.com>
To: Al Viro <viro@ZenIV.linux.org.uk>
CC: "linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] Validate pointer when copying mount namespace.
Thread-Topic: [PATCH] Validate pointer when copying mount namespace.
Thread-Index: AQHQgiVIMSAde0/xbkGZKAxJaHP0H51jUVLQ
Date: Wed, 29 Apr 2015 03:21:25 +0000
Message-ID: <3917C05D9F83184EAA45CE249FF1B1DD026EA3D0@SHSMSX103.ccr.corp.intel.com>
References: <y> <1430272604-6701-1-git-send-email-xindong.ma@intel.com>
 <20150429023613.GM889@ZenIV.linux.org.uk>
In-Reply-To: <20150429023613.GM889@ZenIV.linux.org.uk>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [10.239.127.40]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 8BIT
MIME-Version: 1.0
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 780
Lines: 13

> Details, please.  How do you reproduce that behaviour?
> 
> I don't like that loop in its current form (it relies upon _not_ encountering the
> same ->mnt_root in the parts of tree we hadn't copied), but your change
> doesn't make it any better.  Seeing a reproducer would be useful in sorting it
> out; in this form the patch papers over the bug rather than fixing it.

The issue is reproduced during monkey test on android devices. Seems it's very hard to reproduce it again. I'll continue to perform the test and review the code.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/