Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753434AbbD2Fmo (ORCPT ); Wed, 29 Apr 2015 01:42:44 -0400 Received: from mail.kernel.org ([198.145.29.136]:47080 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751794AbbD2Fmn (ORCPT ); Wed, 29 Apr 2015 01:42:43 -0400 MIME-Version: 1.0 In-Reply-To: <20150428121234.GA10479@lst.de> References: <1430203717-13307-1-git-send-email-mlin@kernel.org> <1430203717-13307-3-git-send-email-mlin@kernel.org> <20150428121234.GA10479@lst.de> Date: Tue, 28 Apr 2015 22:42:40 -0700 Message-ID: Subject: Re: [PATCH 02/10] block: simplify bio_add_page() From: Ming Lin To: Christoph Hellwig Cc: lkml , Jens Axboe , Kent Overstreet , Dongsu Park , Christoph Hellwig Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 851 Lines: 19 On Tue, Apr 28, 2015 at 5:12 AM, Christoph Hellwig wrote: > On Mon, Apr 27, 2015 at 11:48:29PM -0700, Ming Lin wrote: >> Note that removing call to ->merge_bvec_fn() is fine for >> bio_add_pc_page(), as SCSI devices usually don't even need that. >> Few exceptional cases like pscsi or osd are not affected either. > > This explanation confuses me. Based on my reading of the code I'd > replace it with something like: > > Removing the call to ->merge_bvec_fn() is also fine, as no driver that > implements support for BLOCK_PC commands even has a ->merge_bvec_fn() > method. Will update it. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/