Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1422653AbbD2IRv (ORCPT ); Wed, 29 Apr 2015 04:17:51 -0400 Received: from mx1.redhat.com ([209.132.183.28]:41774 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1031680AbbD2IRt (ORCPT ); Wed, 29 Apr 2015 04:17:49 -0400 Message-ID: <5540939F.70506@redhat.com> Date: Wed, 29 Apr 2015 10:17:35 +0200 From: Paolo Bonzini User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Nadav Amit , Bandan Das CC: kvm list , Jan Kiszka , Wincy Van , linux-kernel@vger.kernel.org Subject: Re: [PATCH] KVM: nVMX: Don't return error on nested bitmap memory allocation failure References: <9C58F44B-0406-4273-BB36-50D39B7C33F9@gmail.com> In-Reply-To: <9C58F44B-0406-4273-BB36-50D39B7C33F9@gmail.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 533 Lines: 15 On 29/04/2015 09:27, Nadav Amit wrote: > free_page appears to check whether the address is zero before it actually > frees the page. Perhaps it is better to leverage this behaviour to remove > all the outX and simplify the code. Agreed. Regarding this patch, I agree with Jan. Paolo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/