Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1422810AbbD2I66 (ORCPT ); Wed, 29 Apr 2015 04:58:58 -0400 Received: from lb1-smtp-cloud6.xs4all.net ([194.109.24.24]:57159 "EHLO lb1-smtp-cloud6.xs4all.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1422711AbbD2I6z (ORCPT ); Wed, 29 Apr 2015 04:58:55 -0400 Message-ID: <1430297931.2411.110.camel@x220> Subject: Re: [PATCH] drivers/nfc: remove obsolete setting of DEBUG From: Paul Bolle To: Valentin Rothberg Cc: Joe Perches , lauro.venancio@openbossa.org, aloisio.almeida@openbossa.org, sameo@linux.intel.com, clement.perrochaud@effinnov.com, charles.gorand@effinnov.com, linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, Andreas Ruprecht , hengelein Stefan Date: Wed, 29 Apr 2015 10:58:51 +0200 In-Reply-To: References: <1430212127-5841-1-git-send-email-valentinrothberg@gmail.com> <1430296046.2411.100.camel@x220> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.10.4 (3.10.4-4.fc20) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1073 Lines: 26 On Wed, 2015-04-29 at 10:45 +0200, Valentin Rothberg wrote: > Thanks, I was not aware of it at all. I read the code and it seems > that if neither DYNAMIC_DEBUG nor DEBUG is defined, pr_debug() does > nothing more than to return 0. > > I am not sure what to do in this case. Somehow it seems reasonable to > me to add NFC_DEBUG to Kconfig since a considerable amount of code in > nfc seems to depend on DEBUG. A few greps tell me the first pointless reference to CONFIG_NFC_DEBUG was added in v3.1. So clearly the people actually building and using the nfc code don't need the DEBUG flag. Apparently using pr_debug() by setting CONFIG_DYNAMIC_DEBUG works for them. (I trust Joe will shout when that statement is incorrect.) So, as I said, the patch should be fine, and only the commit explanation needs work. Paul Bolle -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/