Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1422894AbbD2JwI (ORCPT ); Wed, 29 Apr 2015 05:52:08 -0400 Received: from mail-wi0-f174.google.com ([209.85.212.174]:35074 "EHLO mail-wi0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1422833AbbD2JvZ (ORCPT ); Wed, 29 Apr 2015 05:51:25 -0400 From: =?UTF-8?q?Pali=20Roh=C3=A1r?= To: Matthew Garrett , Darren Hart Cc: platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org, Gabriele Mazzotta , Alex Hung , =?UTF-8?q?Pali=20Roh=C3=A1r?= Subject: [PATCH v2 2/3] platform: x86: dell-rbtn: Export notifier for other kernel modules Date: Wed, 29 Apr 2015 11:51:05 +0200 Message-Id: <1430301066-22870-3-git-send-email-pali.rohar@gmail.com> X-Mailer: git-send-email 1.7.10.4 In-Reply-To: <1430301066-22870-1-git-send-email-pali.rohar@gmail.com> References: <1416755361-17357-1-git-send-email-pali.rohar@gmail.com> <1430301066-22870-1-git-send-email-pali.rohar@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 5667 Lines: 196 This patch exports notifier functions so other modules can receive HW switch events. By default when some module register notifier, dell-rbtn driver automatically remove rfkill interfaces from system (it is expected that other module will use events for other rfkill interface). This behaviour can be changed with new module parameter "auto_remove_rfkill". This patch is designed for dell-laptop module for receiving those events. Signed-off-by: Pali Rohár --- drivers/platform/x86/dell-rbtn.c | 90 +++++++++++++++++++++++++++++++++++++- drivers/platform/x86/dell-rbtn.h | 35 +++++++++++++++ 2 files changed, 123 insertions(+), 2 deletions(-) create mode 100644 drivers/platform/x86/dell-rbtn.h diff --git a/drivers/platform/x86/dell-rbtn.c b/drivers/platform/x86/dell-rbtn.c index 894cd9a..07dfd8f 100644 --- a/drivers/platform/x86/dell-rbtn.c +++ b/drivers/platform/x86/dell-rbtn.c @@ -232,6 +232,80 @@ static struct acpi_driver rbtn_driver = { /* + * notifier export functions + */ + +static bool auto_remove_rfkill = true; + +static ATOMIC_NOTIFIER_HEAD(rbtn_chain_head); + +static int rbtn_inc_count(struct device *dev, void *data) +{ + struct acpi_device *device = to_acpi_device(dev); + struct rbtn_data *rbtn_data = device->driver_data; + int *count = data; + + if (rbtn_data->type == RBTN_SLIDER) + (*count)++; + + return 0; +} + +static int rbtn_switch_dev(struct device *dev, void *data) +{ + struct acpi_device *device = to_acpi_device(dev); + bool enable = data; + + if (enable) + rbtn_rfkill_init(device); + else + rbtn_rfkill_exit(device); + + return 0; +} + +int dell_rbtn_notifier_register(struct notifier_block *nb) +{ + bool first; + int ret; + + ret = 0; + driver_for_each_device(&rbtn_driver.drv, NULL, &ret, rbtn_inc_count); + if (ret == 0) + return -ENODEV; + + first = !rbtn_chain_head.head; + + ret = atomic_notifier_chain_register(&rbtn_chain_head, nb); + if (ret != 0) + return ret; + + if (auto_remove_rfkill && first) + driver_for_each_device(&rbtn_driver.drv, NULL, (void *)false, + rbtn_switch_dev); + + return ret; +} +EXPORT_SYMBOL_GPL(dell_rbtn_notifier_register); + +int dell_rbtn_notifier_unregister(struct notifier_block *nb) +{ + int ret; + + ret = atomic_notifier_chain_unregister(&rbtn_chain_head, nb); + if (ret != 0) + return ret; + + if (auto_remove_rfkill && !rbtn_chain_head.head) + driver_for_each_device(&rbtn_driver.drv, NULL, (void *)true, + rbtn_switch_dev); + + return ret; +} +EXPORT_SYMBOL_GPL(dell_rbtn_notifier_unregister); + + +/* * acpi driver functions */ @@ -265,7 +339,10 @@ static int rbtn_add(struct acpi_device *device) ret = rbtn_input_init(rbtn_data); break; case RBTN_SLIDER: - ret = rbtn_rfkill_init(device); + if (auto_remove_rfkill && rbtn_chain_head.head) + ret = 0; + else + ret = rbtn_rfkill_init(device); break; default: ret = -EINVAL; @@ -314,6 +391,7 @@ static void rbtn_notify(struct acpi_device *device, u32 event) break; case RBTN_SLIDER: rbtn_rfkill_event(device); + atomic_notifier_call_chain(&rbtn_chain_head, event, device); break; default: break; @@ -327,7 +405,9 @@ static void rbtn_notify(struct acpi_device *device, u32 event) static int __init rbtn_init(void) { - return acpi_bus_register_driver(&rbtn_driver); + /* ignore errors so module always loads and exports needed functions */ + acpi_bus_register_driver(&rbtn_driver); + return 0; } static void __exit rbtn_exit(void) @@ -335,9 +415,15 @@ static void __exit rbtn_exit(void) acpi_bus_unregister_driver(&rbtn_driver); } +module_param(auto_remove_rfkill, bool, 0444); module_init(rbtn_init); module_exit(rbtn_exit); +MODULE_PARM_DESC(auto_remove_rfkill, "automatically remove rfkill devices when " + "other module start receiving events from " + "this module and re-add them when last " + "module stop receving events " + "(default true)"); MODULE_DEVICE_TABLE(acpi, rbtn_ids); MODULE_DESCRIPTION("Dell Airplane Mode Switch driver"); MODULE_AUTHOR("Pali Rohár "); diff --git a/drivers/platform/x86/dell-rbtn.h b/drivers/platform/x86/dell-rbtn.h new file mode 100644 index 0000000..d6b44b0 --- /dev/null +++ b/drivers/platform/x86/dell-rbtn.h @@ -0,0 +1,35 @@ +/* + Dell Airplane Mode Switch driver + Copyright (C) 2014-2015 Pali Rohár + + This program is free software; you can redistribute it and/or modify + it under the terms of the GNU General Public License as published by + the Free Software Foundation; either version 2 of the License, or + (at your option) any later version. + + This program is distributed in the hope that it will be useful, + but WITHOUT ANY WARRANTY; without even the implied warranty of + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + GNU General Public License for more details. +*/ + +#ifndef _DELL_RBTN_H_ +#define _DELL_RBTN_H_ + +struct notifier_block; + +#if defined(CONFIG_DELL_RBTN) || defined(CONFIG_DELL_RBTN_MODULE) +int dell_rbtn_notifier_register(struct notifier_block *nb); +int dell_rbtn_notifier_unregister(struct notifier_block *nb); +#else +static inline int dell_rbtn_notifier_register(struct notifier_block *nb) +{ + return -ENODEV; +} +static inline int dell_rbtn_notifier_unregister(struct notifier_block *nb) +{ + return -ENODEV; +} +#endif + +#endif -- 1.7.9.5 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/