Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1422856AbbD2K5p (ORCPT ); Wed, 29 Apr 2015 06:57:45 -0400 Received: from mail-wg0-f48.google.com ([74.125.82.48]:36811 "EHLO mail-wg0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1422664AbbD2K5m (ORCPT ); Wed, 29 Apr 2015 06:57:42 -0400 Date: Wed, 29 Apr 2015 11:57:37 +0100 From: Lee Jones To: Inha Song Cc: devicetree@vger.kernel.org, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, patches@opensource.wolfsonmicro.com, cw00.choi@samsung.com, broonie@kernel.org, ckeepax@opensource.wolfsonmicro.com, rf@opensource.wolfsonmicro.com, robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com, ijc+devicetree@hellion.org.uk Subject: Re: [alsa-devel] [PATCH v2 2/2] mfd: arizona: Update DT binding to support hpdet channel Message-ID: <20150429105737.GZ9169@x1> References: <1429589505-11954-1-git-send-email-ideal.song@samsung.com> <1429589505-11954-3-git-send-email-ideal.song@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1429589505-11954-3-git-send-email-ideal.song@samsung.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1793 Lines: 41 Does this looks okay to you Charles? > This patch add device tree bindings for the pdata needed to configure > the Accessory Detect Mode select when Headphone detection. Isn't the idea of headphone detection that it headphones are detected i.e. automatically? > Signed-off-by: Inha Song > --- > Documentation/devicetree/bindings/mfd/arizona.txt | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/Documentation/devicetree/bindings/mfd/arizona.txt b/Documentation/devicetree/bindings/mfd/arizona.txt > index 7bd1273..3529592 100644 > --- a/Documentation/devicetree/bindings/mfd/arizona.txt > +++ b/Documentation/devicetree/bindings/mfd/arizona.txt > @@ -49,6 +49,12 @@ Optional properties: > input singals. If values less than the number of input signals, elements > that has not been specifed are set to 0 by default. > > + - wlf,hpdet-channel : Headphone detection channel. > + 1 or ARIZONA_ACCDET_MODE_HPL - Headphone detect mode is set to HPDETL > + 2 or ARIZONA_ACCDET_MODE_HPR - Headphone detect mode is set to HPDETR > + If this node is not mentioned or if the value is unknown, then > + headphone detection mode is set to MICDET. > + > - DCVDD-supply, MICVDD-supply : Power supplies, only need to be specified if > they are being externally supplied. As covered in > Documentation/devicetree/bindings/regulator/regulator.txt -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/