Message-ID: <5540BD13.1010408@huawei.com>
Date: Wed, 29 Apr 2015 19:14:27 +0800
From: Xie XiuQi <xiexiuqi@huawei.com>
User-Agent: Mozilla/5.0 (Windows NT 6.1; rv:31.0) Gecko/20100101 Thunderbird/31.5.0
MIME-Version: 1.0
To: <n-horiguchi@ah.jp.nec.com>
CC: <rostedt@goodmis.org>, <mingo@redhat.com>, <akpm@linux-foundation.org>,
        <kirill.shutemov@linux.intel.com>, <koct9i@gmail.com>,
        <hpa@linux.intel.com>, <hannes@cmpxchg.org>, <iamjoonsoo.kim@lge.com>,
        <luto@amacapital.net>, <nasa4836@gmail.com>,
        <gong.chen@linux.intel.com>, <bhelgaas@google.com>, <bp@suse.de>,
        <tony.luck@intel.com>, <linux-kernel@vger.kernel.org>,
        <linux-mm@kvack.org>, <jingle.chen@huawei.com>
Subject: Re: [PATCH v4 0/3] tracing: add trace event for memory-failure
References: <1429519480-11687-1-git-send-email-xiexiuqi@huawei.com>
In-Reply-To: <1429519480-11687-1-git-send-email-xiexiuqi@huawei.com>
Content-Type: text/plain; charset="windows-1252"
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 2284
Lines: 63

Hi Naoya,

Could you help to review and applied this series if possible.

Thanks,
Xie XiuQi

On 2015/4/20 16:44, Xie XiuQi wrote:
> RAS user space tools like rasdaemon which base on trace event, could
> receive mce error event, but no memory recovery result event. So, I
> want to add this event to make this scenario complete.
> 
> This patchset add a event at ras group for memory-failure.
> 
> The output like below:
> #  tracer: nop
> #
> #  entries-in-buffer/entries-written: 2/2   #P:24
> #
> #                               _-----=> irqs-off
> #                              / _----=> need-resched
> #                             | / _---=> hardirq/softirq
> #                             || / _--=> preempt-depth
> #                             ||| /     delay
> #            TASK-PID   CPU#  ||||    TIMESTAMP  FUNCTION
> #               | |       |   ||||       |         |
>        mce-inject-13150 [001] ....   277.019359: memory_failure_event: pfn 0x19869: recovery action for free buddy page: Delayed
> 
> --
> v3->v4:
>  - rebase on top of latest linux-next
>  - update comments as Naoya's suggestion
>  - add #ifdef CONFIG_MEMORY_FAILURE for this trace event
>  - change type of action_result's param 3 to enum
> 
> v2->v3:
>  - rebase on top of linux-next
>  - based on Steven Rostedt's "tracing: Add TRACE_DEFINE_ENUM() macro
>    to map enums to their values" patch set v1.
> 
> v1->v2:
>  - Comment update
>  - Just passing 'result' instead of 'action_name[result]',
>    suggested by Steve. And hard coded there because trace-cmd
>    and perf do not have a way to process enums.
> 
> Xie XiuQi (3):
>   memory-failure: export page_type and action result
>   memory-failure: change type of action_result's param 3 to enum
>   tracing: add trace event for memory-failure
> 
>  include/linux/mm.h      |  34 ++++++++++
>  include/ras/ras_event.h |  85 ++++++++++++++++++++++++
>  mm/memory-failure.c     | 172 ++++++++++++++++++++----------------------------
>  3 files changed, 190 insertions(+), 101 deletions(-)
> 


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/