Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1422778AbbD2L07 (ORCPT ); Wed, 29 Apr 2015 07:26:59 -0400 Received: from mail1.bemta5.messagelabs.com ([195.245.231.146]:18966 "EHLO mail1.bemta5.messagelabs.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753506AbbD2L05 (ORCPT ); Wed, 29 Apr 2015 07:26:57 -0400 X-Env-Sender: stwiss.opensource@diasemi.com X-Msg-Ref: server-15.tower-180.messagelabs.com!1430306814!39970927!1 X-Originating-IP: [94.185.165.51] X-StarScan-Received: X-StarScan-Version: 6.13.6; banners=-,-,- X-VirusChecked: Checked From: "Opensource [Steve Twiss]" To: Lee Jones , "Opensource [Steve Twiss]" CC: DEVICETREE , Ian Campbell , Kumar Gala , LINUXKERNEL , Mark Rutland , Pawel Moll , Rob Herring , Alessandro Zummo , "David Dajun Chen" , Dmitry Torokhov , LINUXINPUT , LINUXWATCHDOG , Liam Girdwood , "Mark Brown" , RTCLINUX , "Samuel Ortiz" , Support Opensource , Wim Van Sebroeck Subject: RE: [PATCH V1 6/6] devicetree: da9062: Add bindings for DA9062 driver Thread-Topic: [PATCH V1 6/6] devicetree: da9062: Add bindings for DA9062 driver Thread-Index: AQHQeRyVWCT9m2ClMkyQ0SFWIiL6j51j0q2AgAAVARA= Date: Wed, 29 Apr 2015 11:26:53 +0000 Message-ID: <6ED8E3B22081A4459DAC7699F3695FB7014B217AE3@SW-EX-MBX02.diasemi.com> References: <94535acf974274822c5ac16d6427299778e11ccf.1429280614.git.stwiss.opensource@diasemi.com> <20150429105415.GX9169@x1> In-Reply-To: <20150429105415.GX9169@x1> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.20.26.77] Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by nfs id t3TBR785025481 Content-Length: 1767 Lines: 51 On 29 April 2015 11:54 Lee Jones wrote : > On Fri, 17 Apr 2015, S Twiss wrote: > > From: S Twiss > > > > Add device tree bindings for the DA9062 driver > > > > Signed-off-by: Steve Twiss > > > > --- > > > > This patch applies against linux-next and v4.0 > > > > Documentation/devicetree/bindings/mfd/da9062.txt | 107 > +++++++++++++++++++++++ > > 1 file changed, 107 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/mfd/da9062.txt > > I don't see anything groundbreaking or offensive. > > Acked-by: Lee Jones > Thank you for the review and Ack. I am in the process of updating the DA9063 OnKey driver in a different thread. This driver is functionally similar to the DA9062 OnKey driver as was discussed in an earlier thread from DA9063. http://www.spinics.net/lists/linux-input/msg38137.html Although the 63 and 62 chips have sequential numbers they are not the same, however the OnKey driver is functionally very similar and so I am going to try and merge the code for both drivers in the case of the OnKey. Due to the DA9063 being currently reviewed, perhaps it would be prudent not to add this device tree bindings for DA9062 to the kernel just yet -- the device tree bindings could change for the OnKey in my DA9063 submission and this would affect the DA9062 driver when I merge the two OnKey drivers. I will put a full version history in my next patch set to describe what changes I have made to this file so this review is not deemed a wasted effort. Regards, Steve [...] ????{.n?+???????+%?????ݶ??w??{.n?+????{??G?????{ay?ʇڙ?,j??f???h?????????z_??(?階?ݢj"???m??????G????????????&???~???iO???z??v?^?m???? ????????I?