Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1422937AbbD2LyJ (ORCPT ); Wed, 29 Apr 2015 07:54:09 -0400 Received: from mail-wi0-f171.google.com ([209.85.212.171]:36116 "EHLO mail-wi0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1422735AbbD2LyH (ORCPT ); Wed, 29 Apr 2015 07:54:07 -0400 Date: Wed, 29 Apr 2015 12:54:02 +0100 From: Lee Jones To: Charles Keepax Cc: broonie@kernel.org, sameo@linux.intel.com, linux-kernel@vger.kernel.org, lgirdwood@gmail.com, patches@opensource.wolfsonmicro.com Subject: Re: [PATCH v2 9/9] mfd: wm5110: Add delay before releasing reset line Message-ID: <20150429115402.GC9169@x1> References: <1429260146-16694-1-git-send-email-ckeepax@opensource.wolfsonmicro.com> <1429260146-16694-10-git-send-email-ckeepax@opensource.wolfsonmicro.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1429260146-16694-10-git-send-email-ckeepax@opensource.wolfsonmicro.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1367 Lines: 45 On Fri, 17 Apr 2015, Charles Keepax wrote: > On the wm5110 it is important the reset line is held for slightly longer > to ensure the device starts up well. This patch adds a 5mS delay for > this. > > Signed-off-by: Charles Keepax > --- > drivers/mfd/arizona-core.c | 9 +++++++++ > 1 files changed, 9 insertions(+), 0 deletions(-) > > diff --git a/drivers/mfd/arizona-core.c b/drivers/mfd/arizona-core.c > index def3ad3..e1f0a68 100644 > --- a/drivers/mfd/arizona-core.c > +++ b/drivers/mfd/arizona-core.c > @@ -259,6 +259,15 @@ static inline void arizona_enable_reset(struct arizona *arizona) > static void arizona_disable_reset(struct arizona *arizona) > { > if (arizona->pdata.reset) { > + switch (arizona->type) { > + case WM5110: > + case WM8280: Comment here please. > + msleep(5); > + break; > + default: > + break; > + } > + > gpio_set_value_cansleep(arizona->pdata.reset, 1); > msleep(1); > } -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/