Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1422974AbbD2Mcd (ORCPT ); Wed, 29 Apr 2015 08:32:33 -0400 Received: from mail-wg0-f46.google.com ([74.125.82.46]:34264 "EHLO mail-wg0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1422934AbbD2Mc2 (ORCPT ); Wed, 29 Apr 2015 08:32:28 -0400 Date: Wed, 29 Apr 2015 13:32:23 +0100 From: Lee Jones To: Arun Bharadwaj Cc: linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org, Jingoo Han , Jean-Christophe Plagniol-Villard , Tomi Valkeinen , Ash Charles Subject: Re: [PATCH] gpio-backlight: Discover driver during boot time Message-ID: <20150429123223.GJ9169@x1> References: <1429143684-3371-1-git-send-email-arun@gumstix.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1429143684-3371-1-git-send-email-arun@gumstix.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1364 Lines: 40 Jingoo? > The gpio-backlight driver seems to be missing the > MODULE_DEVICE_TABLE line which is preventing it from > being modprobed during boot time even if the > gpio-backlight device exists. > > This seems to be a bug and this patch attempts to > fix that. > > Signed-off-by: Arun Bharadwaj > Signed-off-by: Ash Charles > --- > drivers/video/backlight/gpio_backlight.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/video/backlight/gpio_backlight.c b/drivers/video/backlight/gpio_backlight.c > index 439feb2..5fbbc2e 100644 > --- a/drivers/video/backlight/gpio_backlight.c > +++ b/drivers/video/backlight/gpio_backlight.c > @@ -146,6 +146,8 @@ static struct of_device_id gpio_backlight_of_match[] = { > { .compatible = "gpio-backlight" }, > { /* sentinel */ } > }; > + > +MODULE_DEVICE_TABLE(of, gpio_backlight_of_match); > #endif > > static struct platform_driver gpio_backlight_driver = { -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/