Date: Wed, 29 Apr 2015 13:33:03 +0100
From: Lee Jones <lee.jones@linaro.org>
To: Arun Bharadwaj <arun@gumstix.com>
Cc: linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org,
        Jingoo Han <jg1.han@samsung.com>,
        Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>,
        Tomi Valkeinen <tomi.valkeinen@ti.com>,
        Ash Charles <ashcharles@gmail.com>
Subject: Re: [PATCH] gpio-backlight: Discover driver during boot time
Message-ID: <20150429123303.GK9169@x1>
References: <1429143684-3371-1-git-send-email-arun@gumstix.com>
 <20150429123223.GJ9169@x1>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20150429123223.GJ9169@x1>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1454
Lines: 45

> Jingoo?

Never mind.

Applied, thanks.

> > The gpio-backlight driver seems to be missing the
> > MODULE_DEVICE_TABLE line which is preventing it from
> > being modprobed during boot time even if the
> > gpio-backlight device exists.
> > 
> > This seems to be a bug and this patch attempts to
> > fix that.
> > 
> > Signed-off-by: Arun Bharadwaj <arun@gumstix.com>
> > Signed-off-by: Ash Charles <ashcharles@gmail.com>
> > ---
> >  drivers/video/backlight/gpio_backlight.c | 2 ++
> >  1 file changed, 2 insertions(+)
> > 
> > diff --git a/drivers/video/backlight/gpio_backlight.c b/drivers/video/backlight/gpio_backlight.c
> > index 439feb2..5fbbc2e 100644
> > --- a/drivers/video/backlight/gpio_backlight.c
> > +++ b/drivers/video/backlight/gpio_backlight.c
> > @@ -146,6 +146,8 @@ static struct of_device_id gpio_backlight_of_match[] = {
> >  	{ .compatible = "gpio-backlight" },
> >  	{ /* sentinel */ }
> >  };
> > +
> > +MODULE_DEVICE_TABLE(of, gpio_backlight_of_match);
> >  #endif
> >  
> >  static struct platform_driver gpio_backlight_driver = {
> 

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/