Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1423079AbbD2Obd (ORCPT ); Wed, 29 Apr 2015 10:31:33 -0400 Received: from mx08-00178001.pphosted.com ([91.207.212.93]:58334 "EHLO mx08-00178001.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1422821AbbD2Oba (ORCPT ); Wed, 29 Apr 2015 10:31:30 -0400 Message-ID: <5540EB1B.10505@st.com> Date: Wed, 29 Apr 2015 16:30:51 +0200 From: Maxime Coquelin User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: Peter Griffin , , , , , , CC: , Subject: Re: [PATCH v2] ata: ahci_st: fixup layering violations / drvdata errors References: <1429537265-22367-1-git-send-email-peter.griffin@linaro.org> <1429537265-22367-2-git-send-email-peter.griffin@linaro.org> In-Reply-To: <1429537265-22367-2-git-send-email-peter.griffin@linaro.org> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.201.23.80] X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:5.13.68,1.0.33,0.0.0000 definitions=2015-04-29_04:2015-04-29,2015-04-29,1970-01-01 signatures=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1376 Lines: 38 Hi Peter, On 04/20/2015 03:41 PM, Peter Griffin wrote: > Brian noticed while working on another SATA driver that uses libahci_platform, > an error in this driver; it tries to the the driver data for its > device, while libata also thinks it can set the driver data. See: > > ahci_platform_init_host() > -> ata_host_alloc_pinfo() > -> ata_host_alloc() > -> dev_set_drvdata() > > So instead of sticking the IP-specific platform data into drvdata, let's > use the plat_data variable that is reserved for this use. > > Addtionally plat_data isn't set until ahci_platform_init_host() has been > called further down in probe(). So re-work the st_ahci_probe_resets and > st_ahci_deassert_resets functions to take ahci_host_priv *hpriv as a > parameter. > > Signed-off-by: Peter Griffin > Suggested-by: Brian Norris > Cc: Srinivas Kandagatla > Cc: Maxime Coquelin > Cc: Patrice Chotard > --- > You can add my: Acked-by: Maxime Coquelin Thanks! Maxime -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/