Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1423360AbbD2OnT (ORCPT ); Wed, 29 Apr 2015 10:43:19 -0400 Received: from bedivere.hansenpartnership.com ([66.63.167.143]:36734 "EHLO bedivere.hansenpartnership.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1423119AbbD2OnQ (ORCPT ); Wed, 29 Apr 2015 10:43:16 -0400 Message-ID: <1430318594.2189.11.camel@HansenPartnership.com> Subject: Re: [PATCH v8 2/3] scsi: ufs: add debugfs for ufs From: James Bottomley To: Gilad Broner Cc: linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org, linux-arm-msm@vger.kernel.org, santoshsy@gmail.com, linux-scsi-owner@vger.kernel.org, subhashj@codeaurora.org, ygardi@codeaurora.org, draviv@codeaurora.org, Lee Susman , Raviv Shvili , Vinayak Holikatti Date: Wed, 29 Apr 2015 07:43:14 -0700 In-Reply-To: <1429012281-24068-3-git-send-email-gbroner@codeaurora.org> References: <1429012281-24068-1-git-send-email-gbroner@codeaurora.org> <1429012281-24068-3-git-send-email-gbroner@codeaurora.org> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.12.11 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2410 Lines: 64 On Tue, 2015-04-14 at 14:51 +0300, Gilad Broner wrote: > From: Lee Susman > > Adding debugfs capability for ufshcd. > > debugfs attributes introduced in this patch: > - View driver/controller runtime data > - Command tag statistics for performance analisis > - Dump device descriptor info > - Track recoverable errors statistics during runtime > - Change UFS power mode during runtime > entry a string in the format 'GGLLMM' where: > G - selected gear > L - number of lanes > M - power mode > (1=fast mode, 2=slow mode, 4=fast-auto mode, > 5=slow-auto mode) > First letter is for RX, second is for TX. > - Get/set DME attributes > > Signed-off-by: Lee Susman > Signed-off-by: Dolev Raviv > Signed-off-by: Yaniv Gardi > Signed-off-by: Raviv Shvili > Signed-off-by: Gilad Broner Bloody test your damn changes. That means running them through a config options permutation when you introduce config dependencies. This is what happens with CONFIG_DEBUG_FS=n: drivers/scsi/ufs/ufshcd.c:92:9: warning: ‘struct scsi_cmd’ declared inside parameter list [enabled by default] struct scsi_cmd *cmd) ^ drivers/scsi/ufs/ufshcd.c:92:9: warning: its scope is only this definition or declaration, which is probably not what you want [enabled by default] That's a typo inside the other branch of the #ifdef ... apparently none of your reviewers spotted it either. drivers/scsi/ufs/ufs-debugfs.c: In function ‘ufsdbg_tag_stats_show’: drivers/scsi/ufs/ufs-debugfs.c:60:18: error: ‘struct ufs_hba’ has no member named ‘ufs_stats’ ufs_stats = &hba->ufs_stats; ^ ... This lot is obvious: ufs-debufs should not be compiled at all if CONFIG_DEBUG_FS=n >From now on, I'm not taking your code unless it has an external reviewer who makes sure I don't keep running across crap like this. James -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/