Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1423353AbbD2OwM (ORCPT ); Wed, 29 Apr 2015 10:52:12 -0400 Received: from mail-oi0-f46.google.com ([209.85.218.46]:36080 "EHLO mail-oi0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1423104AbbD2OwL (ORCPT ); Wed, 29 Apr 2015 10:52:11 -0400 MIME-Version: 1.0 In-Reply-To: References: From: Pranith Kumar Date: Wed, 29 Apr 2015 10:51:40 -0400 Message-ID: Subject: Re: [PATCH] compiler-intel: fix wrong compiler barrier() macro To: Daniel Borkmann Cc: "H. Peter Anvin" , LKML , Ingo Molnar , mancha security Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 972 Lines: 23 Hi Daniel, On Wed, Apr 29, 2015 at 10:42 AM, Daniel Borkmann wrote: > Cleanup commit 23ebdedc67e ("compiler-intel.h: Remove duplicate > definition") removed the double definition of __memory_barrier() > intrinsics. > > However, in doing so, it also removed the preceding #undef barrier, > meaning, the actual barrier() macro from compiler-gcc.h with inline > asm is still in place when __GNUC__ is provided. When you use the Intel compilers, the barrier() definition will come from compiler.h and not compiler-gcc.h. That is what the commit message says in 73679e508201(your commit message has the wrong hash). I don't understand what problem you are seeing with this, can you please explain? Thanks! -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/