Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1945945AbbD2PBf (ORCPT ); Wed, 29 Apr 2015 11:01:35 -0400 Received: from cantor2.suse.de ([195.135.220.15]:39301 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1423054AbbD2O4l (ORCPT ); Wed, 29 Apr 2015 10:56:41 -0400 Date: Wed, 29 Apr 2015 16:56:39 +0200 (CEST) From: Jiri Kosina To: Borislav Petkov cc: x86@kernel.org, Josh Poimboeuf , Kees Cook , Seth Jennings , Vojtech Pavlik , linux-kernel@vger.kernel.org, live-patching@vger.kernel.org Subject: Re: [PATCH v2 1/2] x86: introduce kaslr_offset() In-Reply-To: <20150428155958.GG19025@pd.tnic> Message-ID: References: <20150428120838.GA16487@treble.redhat.com> <20150428155958.GG19025@pd.tnic> User-Agent: Alpine 2.00 (LNX 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1825 Lines: 53 On Tue, 28 Apr 2015, Borislav Petkov wrote: > > > Offset that has been chosen for kaslr during kernel decompression can be > > > easily computed as a difference between _text and __START_KERNEL. We are > > > already making use of this in dump_kernel_offset() notifier and in > > > arch_crash_save_vmcoreinfo(). > > > > > > Introduce kaslr_offset() that makes this computation instead of > > > hard-coding it, so that other kernel code (such as live patching) can make > > > use of it. Also convert existing users to make use of it. > > > > > > Signed-off-by: Jiri Kosina > > > --- > > > > > > It'd be great to potentially have Ack from x86 guys for this patch so that > > > I could take it through livepatching.git with the depending 2/2 patch. > > > Thanks. > > > > > > v1 -> v2: convert arch_crash_save_vmcoreinfo(), as spotted by Josh > > > Poimboeuf. > > > > FWIW this patch is equivalent transofrmation without any effects on the > > resulting code: > > > > $ diff -u vmlinux.old.asm vmlinux.new.asm > > --- vmlinux.old.asm 2015-04-28 17:55:19.520983368 +0200 > > +++ vmlinux.new.asm 2015-04-28 17:55:24.141206072 +0200 > > @@ -1,5 +1,5 @@ > > > > -vmlinux.old: file format elf64-x86-64 > > +vmlinux.new: file format elf64-x86-64 > > > > > > Disassembly of section .text: > > $ > > Then those are easy. Please add that piece of infomation to the commit > message. > > With that: > > Acked-by: Borislav Petkov Applied to livepatching.git#for-4.2/kaslr. Thanks, -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/