From: "Suthikulpanit, Suravee" <Suravee.Suthikulpanit@amd.com>
To: Arnd Bergmann <arnd@arndb.de>,
        "linaro-acpi@lists.linaro.org" <linaro-acpi@lists.linaro.org>
CC: "linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>,
        "catalin.marinas@arm.com" <catalin.marinas@arm.com>,
        "rjw@rjwysocki.net" <rjw@rjwysocki.net>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "will.deacon@arm.com" <will.deacon@arm.com>,
        "linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>,
        "lenb@kernel.org" <lenb@kernel.org>,
        "Charles Garcia-Tobin" <Charles.Garcia-Tobin@arm.com>
Subject: Re: [Linaro-acpi] [PATCH 2/2] ACPI / scan: Parse _CCA and setup
 device coherency
Thread-Topic: [Linaro-acpi] [PATCH 2/2] ACPI / scan: Parse _CCA and setup
 device coherency
Thread-Index: AQHQgoKUZmTlGX0FBUKsx9+W4zFieJ1kSIaA//+4B4CAAFRqgP//rsiA
Date: Wed, 29 Apr 2015 14:57:10 +0000
Message-ID: <D1665A4F.19E17%suravee.suthikulpanit@amd.com>
In-Reply-To: <3246744.xVj4sLRlWl@wuerfel>
Accept-Language: en-US
Content-Language: en-US
user-agent: Microsoft-MacOutlook/14.3.0.121105
Content-Type: text/plain; charset="us-ascii"
Content-ID: <6CAF71ED978F994C838BF63F72F3B77F@amd.com>
Content-Transfer-Encoding: 8BIT
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Apr 2015 14:57:13.3024
 (UTC)
X-MS-Exchange-CrossTenant-Id: fde4dada-be84-483f-92cc-e026cbee8e96
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=fde4dada-be84-483f-92cc-e026cbee8e96;Ip=[165.204.84.222];Helo=[atltwp02.amd.com]
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLUPR02MB1105
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 2590
Lines: 75


On 4/29/15, 09:47, "Arnd Bergmann" <arnd@arndb.de> wrote:

>On Wednesday 29 April 2015 09:45:43 Suravee Suthikulpanit wrote:
>> On 04/29/2015 09:03 AM, Arnd Bergmann wrote:
>> > On Wednesday 29 April 2015 08:44:09 Suravee Suthikulpanit wrote:
>> >> +                       device->flags.cca_seen = 1;
>> >> +               } else if (IS_ENABLED(CONFIG_ACPI_MUST_HAVE_CCA)) {
>> >> +                       /*
>> >> +                        * Architecture has specified that if the
>>device
>> >> +                        * can do DMA, it must have ACPI _CCA object.
>> >> +                        * Here, there could be two cases:
>> >> +                        *   1. Not DMA-able device.
>> >> +                        *   2. DMA-able device, but missing _CCA
>>object.
>> >> +                        *
>> >> +                        * In both cases, we will default to dma
>>non-coherent.
>> >> +                        */
>> >> +                       cca = 0;
>> >> +               } else {
>> >> +                       /*
>> >> +                        * If architecture does not specify that
>>device must
>> >> +                        * specify ACPI _CCA (e.g. x86), we default
>>to use
>> >> +                        * dma coherent.
>> >> +                        */
>> >> +                       cca = 1;
>> >> +               }
>> >>
>> >
>> > What does it mean here if a device does DMA but is not coherent? Do
>>you
>> > have an example of a server that needs this?
>> >
>> > Can we please make the default for ARM64 cca=1 as well?
>> >
>> >       Arnd
>> >
>> 
>> Actually, I am trying to implement the logic for when missing _CCA to
>>be 
>> consistent with the behavior when the devicetree entry does not specify
>> "dma-coherent" property. IIUC, in such case, Linux will default to
>>using 
>> non-coherent DMA.
>
>Why?
>
>	Arnd

Otherwise, it would seem inconsistent with what states in the ACPI spec:
 
  CCA objects are only relevant for devices that can access CPU-visible
memory,
  such as devices that are DMA capable. On ARM based systems, the _CCA
object 
  must be supplied all such devices. On Intel platforms, if the _CCA
object is 
  not supplied, the OSPM will assume the devices are hardware cache
coherent.

>From the statement above, I interpreted as if it is not present, it would
be non-coherent.

Suravee

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/