Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1423566AbbD2PBo (ORCPT ); Wed, 29 Apr 2015 11:01:44 -0400 Received: from comal.ext.ti.com ([198.47.26.152]:56083 "EHLO comal.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1423092AbbD2PBk (ORCPT ); Wed, 29 Apr 2015 11:01:40 -0400 Date: Wed, 29 Apr 2015 10:00:05 -0500 From: Felipe Balbi To: "Du, Changbin" CC: "balbi@ti.com" , "stable@vger.kernel.org" , "gregkh@linuxfoundation.org" , "linux-usb@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "Cohen, David A" , "Wu, Hao" Subject: Re: [PATCH v3] usb: gadget: composite: enable BESL support Message-ID: <20150429150005.GA7262@saruman.tx.rr.com> Reply-To: References: <0C18FE92A7765D4EB9EE5D38D86A563A01CDF10A@SHSMSX103.ccr.corp.intel.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="ew6BAiZeqk4r7MaW" Content-Disposition: inline In-Reply-To: <0C18FE92A7765D4EB9EE5D38D86A563A01CDF10A@SHSMSX103.ccr.corp.intel.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3220 Lines: 92 --ew6BAiZeqk4r7MaW Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Apr 29, 2015 at 10:19:13AM +0000, Du, Changbin wrote: > From a6615937bcd9234e6d6bb817c3701fce44d0a84d Mon Sep 17 00:00:00 2001 > From: Felipe Balbi > Date: Tue, 30 Sep 2014 16:08:03 -0500 > Subject: [PATCH] usb: gadget: composite: enable BESL support >=20 > commit a6615937bcd9234e6d6bb817c3701fce44d0a84d upstream. >=20 > According to USB 2.0 ECN Errata for Link Power > Management (USB2-LPM-Errata-final.pdf), BESL > must be enabled if LPM is enabled. >=20 > This helps with USB30CV TD 9.21 LPM L1 > Suspend Resume Test. >=20 I gotta tell you to try once more. What have you missed here ? (Hint: it status with Cc: and ends with # v3.1+) > Signed-off-by: Felipe Balbi > Signed-off-by: Du, Changbin > --- > Hi, >=20 > This patch was introduced on v3.18. However the issue fixed already exist= ed on > v3.1. Thank Balbi for pointing it out. >=20 > So propose to backport it over 3.1+ stable trees as well. >=20 > Change from v2: add upstream commit id in commit message.=20 >=20 > Du, Changbin > --- > drivers/usb/gadget/composite.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/drivers/usb/gadget/composite.c b/drivers/usb/gadget/composit= e.c > index a8c18df..f6a51fd 100644 > --- a/drivers/usb/gadget/composite.c > +++ b/drivers/usb/gadget/composite.c > @@ -560,7 +560,7 @@ static int bos_desc(struct usb_composite_dev *cdev) > usb_ext->bLength =3D USB_DT_USB_EXT_CAP_SIZE; > usb_ext->bDescriptorType =3D USB_DT_DEVICE_CAPABILITY; > usb_ext->bDevCapabilityType =3D USB_CAP_TYPE_EXT; > - usb_ext->bmAttributes =3D cpu_to_le32(USB_LPM_SUPPORT); > + usb_ext->bmAttributes =3D cpu_to_le32(USB_LPM_SUPPORT | USB_BESL_SUPPOR= T); > =20 > /* > * The Superspeed USB Capability descriptor shall be implemented by all > --=20 > 1.9.1 >=20 --=20 balbi --ew6BAiZeqk4r7MaW Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJVQPH1AAoJEIaOsuA1yqRE9WsP/3OEl3uYCdXjIgH08qPUe8ks A9L1/hF9yeJym8w4wkxduwKdtZylRccABdqAW42HAvLWaSz71N3iVIa59CkSbtv/ iZogEd/A7liKQLPIi8R97ShquA5Hb/4++es3wOjARVLjCDFdG1vLZQdY9FhGKEB6 RqMMxqry603a4KKvuAYsi56jDDNuxSf9VmbOkQZpecGMOqofye9csPTR4ItJHuwU 3JX200GKw8TkDkoaewwD2PrOHOz0cyXiEVbLvpz1taiBUqs5IbKdtkGXXPXnjgx/ rz1kqAMHc/I509lazj5h3sil3stHBdLsjx+7t+h4DICzKcdO1ZsNWNNvpUWkDTyY wmN87G5M9eijhgv4VYrGlwGy3PL/A3S2FQDfTAnT0sDXnbjWGHpggd9NrXgUKuFI JOJ7xiRPRBmf7SbtmxLZy7NxVMy6aeOIRCMQSaVOZYPYnkPRMn2bK0FsHWGxl3PF BrXRkX1l7FsVkVAP/Or+8F3J0YyxuB/cS7rBmFRKid+n+fCwdnREkn29np50igQr FjApjV3d7erAvuHLZ5tVmSwcmnO8YjoDl2abLCmhOfCe3Soz4Ek27a3v0qJcmp6I uaW9AQ6QAusOKaCucwItJmQTriie5nPQHrXmv/rr6RB+wXjulePwbw7VQjvxjCdA xtCxXlvHhI9LyJScheLH =r1bH -----END PGP SIGNATURE----- --ew6BAiZeqk4r7MaW-- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/