Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933013AbbD2PMq (ORCPT ); Wed, 29 Apr 2015 11:12:46 -0400 Received: from mailapp01.imgtec.com ([195.59.15.196]:17703 "EHLO mailapp01.imgtec.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753506AbbD2PMo (ORCPT ); Wed, 29 Apr 2015 11:12:44 -0400 Message-ID: <5540F4E9.7010100@imgtec.com> Date: Wed, 29 Apr 2015 16:12:41 +0100 From: Markos Chandras User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: "Maciej W. Rozycki" , James Hogan CC: Leonid Yegoshin , , Ralf Baechle , Subject: Re: [PATCH] MIPS64: R6: R2 emulation bugfix References: <20150428195335.11229.4516.stgit@ubuntu-yegoshin> <5540A1BF.7060408@imgtec.com> In-Reply-To: Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-Originating-IP: [192.168.154.77] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1317 Lines: 37 On 04/29/2015 10:49 AM, Maciej W. Rozycki wrote: > On Wed, 29 Apr 2015, James Hogan wrote: > >>> Error recovery pointers for fixups was improperly set as ".word" >>> which is unsuitable for MIPS64. >>> >>> Replaced by __stringify(PTR) >> >> Every other case of this sort of thing uses STR(PTR) (or __UA_ADDR in >> uaccess.h). Can we stick to STR(PTR) for consistency please? > > Or __PA_ADDR in paccess.h. > > I have mixed feelings, the reason for __stringify being absent is the > macro being generic and more recently added than pieces of code that use > STR, e.g. unaligned.c that has been there since forever. And we do use > __stringify in many other cases. > > On the other hand STR is short and sweet, unlike __stringify. The patch overall looks good to me so here is my Reviewed-by: Markos Chandras I do agree with James that it would be nice to have it in stable 4.0+ as well. I don't particularly care if STR() is going to be used at the end or we stick to __stringify. Both are used in arch/mips/* anyway -- markos -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/