Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753662AbbD2Pgf (ORCPT ); Wed, 29 Apr 2015 11:36:35 -0400 Received: from smtprelay0070.hostedemail.com ([216.40.44.70]:45832 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753561AbbD2Pge convert rfc822-to-8bit (ORCPT ); Wed, 29 Apr 2015 11:36:34 -0400 X-Session-Marker: 726F737465647440676F6F646D69732E6F7267 X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,rostedt@goodmis.org,:::::::::::::,RULES_HIT:41:152:355:379:541:599:800:960:973:988:989:1260:1277:1311:1313:1314:1345:1359:1431:1437:1513:1515:1516:1518:1521:1534:1539:1593:1594:1711:1730:1747:1777:1792:2393:2553:2559:2562:3138:3139:3140:3141:3142:3352:3622:3865:3866:3867:3868:3872:4362:5007:6261:7875:8603:10004:10400:10848:10967:11232:11658:11914:12114:12517:12519:12740:13069:13095:13311:13357:21080,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0 X-HE-Tag: wine43_734070eb9583c X-Filterd-Recvd-Size: 1777 Date: Wed, 29 Apr 2015 11:36:30 -0400 From: Steven Rostedt To: Alex =?UTF-8?B?QmVubsOpZQ==?= Cc: mingo@redhat.com, Dave.Martin@arm.com, linux-kernel@vger.kernel.org, Oleg Nesterov , Javi Merino , "Peter Zijlstra (Intel)" Subject: Re: [PATCH v2] tracing: make ftrace_print_array_seq compute buf_len Message-ID: <20150429113630.7595e9ce@gandalf.local.home> In-Reply-To: <1430320727-14582-1-git-send-email-alex.bennee@linaro.org> References: <1430320727-14582-1-git-send-email-alex.bennee@linaro.org> X-Mailer: Claws Mail 3.11.1 (GTK+ 2.24.25; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 971 Lines: 29 On Wed, 29 Apr 2015 16:18:46 +0100 Alex Bennée wrote: > The only caller to this function (__print_array) was getting it wrong by > passing the array length instead of buffer length. As the element size > was already being passed for other reasons it seems reasonable to push > the calculation of buffer length into the function. > > Signed-off-by: Alex Bennée Thanks, I'll add a stable tag to this too, and get it out soon. -- Steve > > --- > v2: > - more explicit commit message > - rename len -> count to reduce ambiguity > --- > include/linux/ftrace_event.h | 2 +- > kernel/trace/trace_output.c | 3 ++- > 2 files changed, 3 insertions(+), 2 deletions(-) > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/