Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966313AbbD2Pyg (ORCPT ); Wed, 29 Apr 2015 11:54:36 -0400 Received: from eu-smtp-delivery-143.mimecast.com ([146.101.78.143]:61188 "EHLO eu-smtp-delivery-143.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S966285AbbD2Pyf convert rfc822-to-8bit (ORCPT ); Wed, 29 Apr 2015 11:54:35 -0400 Message-ID: <5540FEB8.1070605@arm.com> Date: Wed, 29 Apr 2015 16:54:32 +0100 From: Dietmar Eggemann User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: "pang.xunlei@zte.com.cn" , Morten Rasmussen CC: Juri Lelli , "linux-kernel@vger.kernel.org" , "linux-kernel-owner@vger.kernel.org" , "mingo@redhat.com" , "mturquette@linaro.org" , "nico@linaro.org" , "peterz@infradead.org" , "preeti@linux.vnet.ibm.com" , "rjw@rjwysocki.net" , "vincent.guittot@linaro.org" , "yuyang.du@intel.com" Subject: Re: [RFCv3 PATCH 29/48] sched: Highest energy aware balancing sched_domain level pointer References: <1423074685-6336-1-git-send-email-morten.rasmussen@arm.com> <1423074685-6336-30-git-send-email-morten.rasmussen@arm.com> In-Reply-To: X-OriginalArrivalTime: 29 Apr 2015 15:54:31.0499 (UTC) FILETIME=[C7F139B0:01D08294] X-MC-Unique: QNhOCEJBQ3GqOf34cmzByg-1 Content-Type: text/plain; charset=WINDOWS-1252 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1322 Lines: 35 On 28/04/15 10:09, pang.xunlei@zte.com.cn wrote: > Morten Rasmussen wrote 2015-02-05 AM 02:31:06: > >> Morten Rasmussen >> [RFCv3 PATCH 29/48] sched: Highest energy aware balancing >> sched_domain level pointer >> >> Add another member to the family of per-cpu sched_domain shortcut >> pointers. This one, sd_ea, points to the highest level at which energy >> model is provided. At this level and all levels below all sched_groups >> have energy model data attached. [...] >> @@ -5766,6 +5767,14 @@ static void update_top_cache_domain(int cpu) >> >> sd = highest_flag_domain(cpu, SD_ASYM_PACKING); >> rcu_assign_pointer(per_cpu(sd_asym, cpu), sd); >> + >> + for_each_domain(cpu, sd) { >> + if (sd->groups->sge) > > sge is like sgc, I think the test will always return true, no? True for the current implementation. This code will make more sense once we integrate the changes you proposed for '[RFCv3 PATCH 23/48] sched: Allocate and initialize energy data structures' into the next version. [...] -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/