Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1030627AbbD2P7l (ORCPT ); Wed, 29 Apr 2015 11:59:41 -0400 Received: from e23smtp02.au.ibm.com ([202.81.31.144]:43137 "EHLO e23smtp02.au.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753852AbbD2P7f (ORCPT ); Wed, 29 Apr 2015 11:59:35 -0400 Message-ID: <5540FFAE.2050502@linux.vnet.ibm.com> Date: Wed, 29 Apr 2015 21:28:38 +0530 From: Shreyas B Prabhu User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.1.0 MIME-Version: 1.0 To: Steven Rostedt CC: Preeti Murthy , Paul McKenney , LKML , Ingo Molnar , aneesh.kumar@linux.vnet.ibm.com, Preeti U Murthy Subject: Re: [PATCH 3/3] tracing/mm: Don't trace mm_page_pcpu_drain on offline cpus References: <1430236283-29360-1-git-send-email-shreyas@linux.vnet.ibm.com> <1430236283-29360-3-git-send-email-shreyas@linux.vnet.ibm.com> <5540EF78.8000409@linux.vnet.ibm.com> <20150429111812.60b697c6@gandalf.local.home> In-Reply-To: <20150429111812.60b697c6@gandalf.local.home> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 15042915-0005-0000-0000-000001B67B73 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 857 Lines: 24 On Wednesday 29 April 2015 08:48 PM, Steven Rostedt wrote: > On Wed, 29 Apr 2015 20:19:28 +0530 > Shreyas B Prabhu wrote: > >> IIUC there is no existing macro which can both add a condition and >> override printk format, hence the fall back to TRACE_EVENT_CONDITION. > > Hmm, want me to send you a patch that changes that? > I am not sure if its worth the effort now. It doesn't look like any other trace point apart from the above use case will benefit from it. Only smbus_write and smbus_reply seem to come close. But even they need separate TP_fast_assign. Thanks, Shreyas -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/