Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753849AbbD2P72 (ORCPT ); Wed, 29 Apr 2015 11:59:28 -0400 Received: from mx1.redhat.com ([209.132.183.28]:45073 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753599AbbD2P71 (ORCPT ); Wed, 29 Apr 2015 11:59:27 -0400 Message-ID: <5540FFD9.4050100@redhat.com> Date: Wed, 29 Apr 2015 17:59:21 +0200 From: Jerome Marchand User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: "Kirill A. Shutemov" , Andrew Morton , Andrea Arcangeli , Hugh Dickins CC: Dave Hansen , Mel Gorman , Rik van Riel , Vlastimil Babka , Christoph Lameter , Naoya Horiguchi , Steve Capper , "Aneesh Kumar K.V" , Johannes Weiner , Michal Hocko , Sasha Levin , linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCHv5 08/28] khugepaged: ignore pmd tables with THP mapped with ptes References: <1429823043-157133-1-git-send-email-kirill.shutemov@linux.intel.com> <1429823043-157133-9-git-send-email-kirill.shutemov@linux.intel.com> In-Reply-To: <1429823043-157133-9-git-send-email-kirill.shutemov@linux.intel.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="bVU0EXvulTMJdRN9NkSFCBE2sLMReps5V" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2543 Lines: 73 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --bVU0EXvulTMJdRN9NkSFCBE2sLMReps5V Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable On 04/23/2015 11:03 PM, Kirill A. Shutemov wrote: > Prepare khugepaged to see compound pages mapped with pte. For now we > won't collapse the pmd table with such pte. >=20 > khugepaged is subject for future rework wrt new refcounting. >=20 > Signed-off-by: Kirill A. Shutemov > Tested-by: Sasha Levin Acked-by: Jerome Marchand > --- > mm/huge_memory.c | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) >=20 > diff --git a/mm/huge_memory.c b/mm/huge_memory.c > index fa3d4f78b716..ffc30e4462c1 100644 > --- a/mm/huge_memory.c > +++ b/mm/huge_memory.c > @@ -2653,6 +2653,11 @@ static int khugepaged_scan_pmd(struct mm_struct = *mm, > page =3D vm_normal_page(vma, _address, pteval); > if (unlikely(!page)) > goto out_unmap; > + > + /* TODO: teach khugepaged to collapse THP mapped with pte */ > + if (PageCompound(page)) > + goto out_unmap; > + > /* > * Record which node the original page is from and save this > * information to khugepaged_node_load[]. > @@ -2663,7 +2668,6 @@ static int khugepaged_scan_pmd(struct mm_struct *= mm, > if (khugepaged_scan_abort(node)) > goto out_unmap; > khugepaged_node_load[node]++; > - VM_BUG_ON_PAGE(PageCompound(page), page); > if (!PageLRU(page) || PageLocked(page) || !PageAnon(page)) > goto out_unmap; > /* >=20 --bVU0EXvulTMJdRN9NkSFCBE2sLMReps5V Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJVQP/ZAAoJEHTzHJCtsuoCEm0H/3DwdTYmET6xFbPCUp+fnrcU ft5A43mwMvO0jxlNqt7wXe/YQ1gdrqETBzWeCd/xEICykvgeQKMkijV4yDm9AZLu NnNMwKfRfhosg9Yx2VLT64jJvAAz9lIzc7wQTN9T6bYnUjby0GHbRffPszblcrTP /L9/a0r6fEI8p2FMYwag81EZ9z5lYqU/7Q65bgCmLT87zPPOn39+i3Z2tdOQ9nzU gyj/CUwpYt6hCDhz82R9Q9XkVdl2yDU/cTZYiIa6i7RqJe79J1H+DVtnUkUOdOYW /4zGwZ0wyd1Rtx0VMthdpXXVA+j5VsOksQtPJJ+dpk70CkqxZizMzvQpCnucs50= =zcfB -----END PGP SIGNATURE----- --bVU0EXvulTMJdRN9NkSFCBE2sLMReps5V-- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/