Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966348AbbD2QCS (ORCPT ); Wed, 29 Apr 2015 12:02:18 -0400 Received: from static.88-198-71-155.clients.your-server.de ([88.198.71.155]:59110 "EHLO socrates.bennee.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965370AbbD2QCO (ORCPT ); Wed, 29 Apr 2015 12:02:14 -0400 References: <1430320727-14582-1-git-send-email-alex.bennee@linaro.org> <20150429113630.7595e9ce@gandalf.local.home> From: Alex =?utf-8?Q?Benn=C3=A9e?= To: Steven Rostedt Cc: mingo@redhat.com, Dave.Martin@arm.com, linux-kernel@vger.kernel.org, Oleg Nesterov , Javi Merino , "Peter Zijlstra \(Intel\)" Subject: Re: [PATCH v2] tracing: make ftrace_print_array_seq compute buf_len In-reply-to: <20150429113630.7595e9ce@gandalf.local.home> Date: Wed, 29 Apr 2015 17:02:50 +0100 Message-ID: <87mw1q2a8l.fsf@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-SA-Exim-Connect-IP: 127.0.0.1 X-SA-Exim-Mail-From: alex.bennee@linaro.org X-SA-Exim-Scanned: No (on socrates.bennee.com); SAEximRunCond expanded to false Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1323 Lines: 42 Steven Rostedt writes: > On Wed, 29 Apr 2015 16:18:46 +0100 > Alex Bennée wrote: > >> The only caller to this function (__print_array) was getting it wrong by >> passing the array length instead of buffer length. As the element size >> was already being passed for other reasons it seems reasonable to push >> the calculation of buffer length into the function. >> >> Signed-off-by: Alex Bennée > > Thanks, I'll add a stable tag to this too, and get it out soon. I take it you'll pick up Dave's reviewed-by? As for CC'ing stable I wouldn't worry too much as nothing in the kernel uses __print_array yet (unless you count the example). But it is a fairly trivial patch so if you as the maintainer is happy I'm happy ;-) > > -- Steve > >> >> --- >> v2: >> - more explicit commit message >> - rename len -> count to reduce ambiguity >> --- >> include/linux/ftrace_event.h | 2 +- >> kernel/trace/trace_output.c | 3 ++- >> 2 files changed, 3 insertions(+), 2 deletions(-) >> -- Alex Bennée -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/