Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S933303AbbD2QMG (ORCPT <rfc822;w@1wt.eu>);
	Wed, 29 Apr 2015 12:12:06 -0400
Received: from mail-ob0-f170.google.com ([209.85.214.170]:33170 "EHLO
	mail-ob0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S933223AbbD2QMB (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Wed, 29 Apr 2015 12:12:01 -0400
MIME-Version: 1.0
In-Reply-To: <20150429160233.GA8427@krava.redhat.com>
References: <1430322871-18107-1-git-send-email-namhyung@kernel.org> <20150429160233.GA8427@krava.redhat.com>
From: Namhyung Kim <namhyung@kernel.org>
Date: Thu, 30 Apr 2015 01:11:40 +0900
X-Google-Sender-Auth: sC_50x_7LP2US-DPSfNYkFndNGs
Message-ID: <CAM9d7chr1-aRDsHEpr1vApgfYns85FvVaHQc3JmdhHVzscKt_w@mail.gmail.com>
Subject: Re: [PATCH] perf tools: Fix bison-related build failure on CentOS 6
To: Jiri Olsa <jolsa@redhat.com>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>, Ingo Molnar <mingo@kernel.org>,
        Peter Zijlstra <a.p.zijlstra@chello.nl>,
        LKML <linux-kernel@vger.kernel.org>, David Ahern <dsahern@gmail.com>
Content-Type: text/plain; charset=UTF-8
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1873
Lines: 54

On Thu, Apr 30, 2015 at 1:02 AM, Jiri Olsa <jolsa@redhat.com> wrote:
> On Thu, Apr 30, 2015 at 12:54:31AM +0900, Namhyung Kim wrote:
>> The YYLTYPE_IS_TRIVIAL is defined in the Build file, but unlike
>> pmu-bison.c, gcc complained about it for parse-events-bison.c:
>
> any clue why is that? cant see why Fedora is not complaining
> over the same sources and RHEL6 fails..

I have no idea.  I just found it during build test using containers,
and had no chance to look into the bison code..

Thanks,
Namhyung


>>
>>     CC       util/parse-events-bison.o
>>   In file included from util/parse-events.y:16:
>>   util/parse-events-bison.h:101:1: error: "YYLTYPE_IS_TRIVIAL" redefined
>>   <command-line>: error: this is the location of the previous definition
>>   make[3]: *** [util/parse-events-bison.o] Error 1
>>
>> Signed-off-by: Namhyung Kim <namhyung@kernel.org>
>> ---
>>  tools/perf/util/Build | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/tools/perf/util/Build b/tools/perf/util/Build
>> index b6c3f39f081a..28af8e2825b3 100644
>> --- a/tools/perf/util/Build
>> +++ b/tools/perf/util/Build
>> @@ -118,7 +118,7 @@ $(OUTPUT)util/pmu-bison.c: util/pmu.y
>>
>>  CFLAGS_parse-events-flex.o  += -w
>>  CFLAGS_pmu-flex.o           += -w
>> -CFLAGS_parse-events-bison.o += -DYYENABLE_NLS=0 -DYYLTYPE_IS_TRIVIAL=0 -w
>> +CFLAGS_parse-events-bison.o += -DYYENABLE_NLS=0 -w
>>  CFLAGS_pmu-bison.o          += -DYYENABLE_NLS=0 -DYYLTYPE_IS_TRIVIAL=0 -w
>>
>>  $(OUTPUT)util/parse-events.o: $(OUTPUT)util/parse-events-flex.c $(OUTPUT)util/parse-events-bison.c
>> --
>> 2.3.5
>>



-- 
Thanks,
Namhyung
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/