Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933335AbbD2QRG (ORCPT ); Wed, 29 Apr 2015 12:17:06 -0400 Received: from mail-wi0-f173.google.com ([209.85.212.173]:36391 "EHLO mail-wi0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933068AbbD2QRD (ORCPT ); Wed, 29 Apr 2015 12:17:03 -0400 From: Javi Merino To: Steven Rostedt CC: =?utf-8?B?QWxleCBCZW5uw6ll?= , "mingo@redhat.com" , Dave P Martin , "linux-kernel@vger.kernel.org" , Oleg Nesterov , "Peter Zijlstra (Intel)" Date: Wed, 29 Apr 2015 17:12:21 +0100 Subject: Re: [PATCH v2] tracing: make ftrace_print_array_seq compute buf_len Thread-Topic: [PATCH v2] tracing: make ftrace_print_array_seq compute buf_len Message-ID: <20150429161221.GI3054@e104805> References: <1430320727-14582-1-git-send-email-alex.bennee@linaro.org> <20150429113630.7595e9ce@gandalf.local.home> <87mw1q2a8l.fsf@linaro.org> <20150429120622.48c62110@gandalf.local.home> In-Reply-To: <20150429120622.48c62110@gandalf.local.home> Accept-Language: en-US, en-GB Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mutt/1.5.21 (2010-09-15) MIME-Version: 1.0 X-OriginalArrivalTime: 29 Apr 2015 16:13:45.0235 (UTC) FILETIME=[779F5E30:01D08297] X-MC-Unique: mLKypS-_RrmJtxOaUTS3Kg-1 Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by nfs id t3TGHGKj027538 Content-Length: 1500 Lines: 37 On Wed, Apr 29, 2015 at 05:06:22PM +0100, Steven Rostedt wrote: > On Wed, 29 Apr 2015 17:02:50 +0100 > Alex Bennée wrote: > > > > > Steven Rostedt writes: > > > > > On Wed, 29 Apr 2015 16:18:46 +0100 > > > Alex Bennée wrote: > > > > > >> The only caller to this function (__print_array) was getting it wrong by > > >> passing the array length instead of buffer length. As the element size > > >> was already being passed for other reasons it seems reasonable to push > > >> the calculation of buffer length into the function. > > >> > > >> Signed-off-by: Alex Bennée > > > > > > Thanks, I'll add a stable tag to this too, and get it out soon. > > > > I take it you'll pick up Dave's reviewed-by? > > Yep, I will. > > > > > As for CC'ing stable I wouldn't worry too much as nothing in the kernel > > uses __print_array yet (unless you count the example). But it is a > > fairly trivial patch so if you as the maintainer is happy I'm happy ;-) > > OK, if it's not used, then I'll just add it to this release. Our maintainer missed the merge window (sigh) so the patches that were going to use this will have to wait until linux v4.2. So they will be users in the future, but there's no need for this to go to stable. Cheers, Javi ????{.n?+???????+%?????ݶ??w??{.n?+????{??G?????{ay?ʇڙ?,j??f???h?????????z_??(?階?ݢj"???m??????G????????????&???~???iO???z??v?^?m???? ????????I?