Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1031761AbbD2Q3P (ORCPT ); Wed, 29 Apr 2015 12:29:15 -0400 Received: from mail-wi0-f176.google.com ([209.85.212.176]:37500 "EHLO mail-wi0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753599AbbD2Q2o (ORCPT ); Wed, 29 Apr 2015 12:28:44 -0400 Date: Wed, 29 Apr 2015 18:28:40 +0200 From: Pali =?utf-8?B?Um9ow6Fy?= To: Gabriele Mazzotta Cc: Matthew Garrett , Darren Hart , platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org, Alex Hung Subject: Re: [PATCH v2 1/3] platform: x86: dell-rbtn: Dell Airplane Mode Switch driver Message-ID: <20150429162840.GN24346@pali> References: <1416755361-17357-1-git-send-email-pali.rohar@gmail.com> <37641224.OJKZVtGCPV@xps13> <20150429130840.GI24346@pali> <2564950.goQdGu3mlb@xps13> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <2564950.goQdGu3mlb@xps13> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1802 Lines: 38 On Wednesday 29 April 2015 15:57:58 Gabriele Mazzotta wrote: > On Wednesday 29 April 2015 15:08:40 Pali Rohár wrote: > > On Wednesday 29 April 2015 12:30:32 Gabriele Mazzotta wrote: > > > On Wednesday 29 April 2015 11:51:04 Pali Rohár wrote: > > > > This is an ACPI driver for Dell laptops which receive HW switch events. > > > > It exports rfkill device dell-rbtn which provide correct hard rfkill state. > > > > > > > > Alex Hung added code for supporting Dell laptops which have toggle button > > > > instead HW slider switch. On these laptops toggle button event is reported > > > > by new input device (instead rfkill) as they do not have hw radio switch. > > > > > > > > It looks like those are two different functions (rfkill, input device), but > > > > Dell BIOS exports them via same ACPI device and uses same ACPI functions. > > > > So code is in one kernel driver. > > > > > > I made a patch some time ago that I've just adapted. It allows to > > > prefer RBTN_SLIDER over RBTN_TOGGLE. The main reason why I'd like to > > > have the hardware switch is that the BIOS doesn't alter the soft state > > > of the devices. This comes in handy when the function key controls > > > multiple radio devices. > > > > > > > Now I'm thinking... is't this bug in wifi kernel driver (which exports > > phy rfkill)? Or problem somewhere else (userspace or kernel)? > > What is the presumed bug you are referring to? The fact that the soft state > doesn't change? Can you remind me whats the problem on your laptop? -- Pali Rohár pali.rohar@gmail.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/