Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966371AbbD2Qkr (ORCPT ); Wed, 29 Apr 2015 12:40:47 -0400 Received: from mail-oi0-f45.google.com ([209.85.218.45]:33120 "EHLO mail-oi0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751647AbbD2Qkq (ORCPT ); Wed, 29 Apr 2015 12:40:46 -0400 MIME-Version: 1.0 In-Reply-To: <20150429145956.GB12861@zoho.com> References: <20150429145956.GB12861@zoho.com> From: Pranith Kumar Date: Wed, 29 Apr 2015 12:40:15 -0400 Message-ID: Subject: Re: [PATCH] compiler-intel: fix wrong compiler barrier() macro To: mancha security Cc: Daniel Borkmann , "H. Peter Anvin" , LKML , Ingo Molnar Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 749 Lines: 18 On Wed, Apr 29, 2015 at 10:59 AM, mancha security wrote: > > The problem is that ICC defines __GNUC__ so barrier() gets defined > in compiler-gcc.h. Your commit removed an #undef from compiler-intel.h > so compiler.h will never define barrier to __memory_barrier(). > OK, I see your point. But, ICC has support for GCC inline assembly. So the change does not seem to be making any difference. We are using our own asm barrier rather than the inbuilt one provided by ICC. -- Pranith -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/